Skip to content

DiscLayer,CylinderLayer use unique_ptr for IApproachDescriptor,...

Christos Anastopoulos requested to merge ATLAS-EGamma/athena:DiscLayer_leak into master
  • DiscLayer,CylinderLayer use unique_ptr for IApproachDescriptor,
  • IApproachDescriptor actually delete the ptr i.e use unique_ptr

One issue that files had quite ^M characters so in the .cxx the changes look a bit more significant that they are. (e.g DiscLayer.cxx and CylinderLayer.cxx is the same bar the ^M and the unique_ptr)

Anyhow, lets see if the CI succeeds as ownership at the level of the IApproachDescriptor was not obvious.

It was not deleting the pointer to ApproachSurfacesit was holding (or any of them in this matter of fact), so lets see if is OK to move it to unique_ptr, and also actually delete surfaces it holds when they are free. Since ApproachSurfaces dtor was not called this was not the case either.

Edited by Christos Anastopoulos

Merge request reports