DiscLayer,CylinderLayer use unique_ptr for IApproachDescriptor,...
- DiscLayer,CylinderLayer use unique_ptr for IApproachDescriptor,
- IApproachDescriptor actually delete the ptr i.e use unique_ptr
One issue that files had quite ^M characters so in the .cxx the changes look a bit more significant that they are. (e.g DiscLayer.cxx and CylinderLayer.cxx is the same bar the ^M and the unique_ptr)
Anyhow, lets see if the CI succeeds as ownership at the level of the IApproachDescriptor was not obvious.
It was not deleting the pointer to ApproachSurfacesit was holding (or any of them in this matter of fact), so lets see if is OK to move it to unique_ptr,
and also actually delete surfaces it holds when they are free. Since ApproachSurfaces dtor was not called this was not the case either.
Merge request reports
Activity
added Tracking master review-pending-level-1 labels
-
Athena AthSimulation AnalysisBase AthGeneration externals 
cmake make 
required tests optional tests 
Full details available on this CI monitor view
added review-user-action-required label and removed review-pending-level-1 label
Hi, please fix the compilation error:
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/InnerDetector/InDetDetDescr/InDetTrackingGeometry/src/TRT_LayerBuilderCond.cxx:439:123: error: no matching function for call to 'Trk::ApproachDescriptor::ApproachDescriptor(Trk::BinnedArray2DTrk::ApproachSurfaces*&, Trk::CylinderSurface*&)' Trk::ApproachDescriptor* aDescritpor = new Trk::ApproachDescriptor(aDescriptorBinnedArray, approachSurface);
and have a look at failed tests.
Magdalena (L1 shifter)
added InnerDetector review-pending-level-1 labels and removed review-user-action-required label
For some reason will be suprised if the ownership is not a bit weirder that I assume here .... but lets hope for success . In principle unique_ptr seem like they should work...
Edited by Christos Anastopoulos-
Athena AthSimulation AnalysisBase AthGeneration externals cmake make required tests optional tests Full details available on this CI monitor view
