Skip to content
Snippets Groups Projects

AnalysisTop, adding code to handle DAOD_PHYS truth record

Merged Marco Vanadia requested to merge mvanadia/athena:21.2-ATDAOD_PHYS_Truth into 21.2

code to handle DAOD_PHYS truth record in AnalysisTop, where TruthParticles collection is not avaialble but we have to use individual object collections

Edited by Marco Vanadia

Merge request reports

Pipeline #1792836 passed

Pipeline passed for 1311aa8d on mvanadia:21.2-ATDAOD_PHYS_Truth

Approval is optional

Merged by Nils Erik KrumnackNils Erik Krumnack 4 years ago (Jul 15, 2020 12:13am UTC)

Merge details

  • Changes merged into master with eb7adf9e.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Marco Vanadia added 1 commit

    added 1 commit

    Compare with previous version

  • Marco Vanadia resolved all threads

    resolved all threads

  • Marco Vanadia unmarked as a Work In Progress

    unmarked as a Work In Progress

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 168K in file PhysicsAnalysis/TopPhys/xAOD/TopConfiguration/Root/TopConfig.cxx

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 168K in file PhysicsAnalysis/TopPhys/xAOD/TopConfiguration/Root/TopConfig.cxx

  • This merge request affects 3 packages:

    • PhysicsAnalysis/TopPhys/xAOD/TopAnalysis
    • PhysicsAnalysis/TopPhys/xAOD/TopConfiguration
    • PhysicsAnalysis/TopPhys/xAOD/TopPartons

    Adding @omajersk ,@yili ,@mvanadia ,@tdado as watchers

  • :pencil: Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

    • Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other projects) results, sometimes for additional hour or two.
  • :white_check_mark: CI Result SUCCESS (hash f80cac60)

    AthDerivation
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    required tests :white_check_mark:
    optional tests :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: AthDerivation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 44357]

  • :pencil: Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

    • Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other projects) results, sometimes for additional hour or two.
  • :white_check_mark: CI Result SUCCESS (hash f80cac60)

    AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :warning:
    required tests :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :warning: AthAnalysis: number of compilation errors 0, warnings 6
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 16774]

  • Hi, the change and test result looks fine, would you @xiaozhon please double check and we could ask to merge it. Best, Rui, AR shifter

  • Tomasz Bold
  • Tomasz Bold
  • Tomasz Bold
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading