r22: cleanup TRT dEdx tool and harmonise use of TRT raw data
This MR harmonises the interpretation of the bit patterns of TRT hits and removes code duplication. It also removes superfluous parts of the TRT dEdx tool and moves the calculation of the time over threshold to the DriftCircle object, where it belongs.
This is a summary of the changes and expected side effects:
- Only a single implementation of the bit pattern interpretation in
TRT_LoLumRawData
, re-used byTRT_DriftCircle
. - The relevant bit pattern is now always the (first) largest consecutive pattern of 1s ("largest island") within the time window. In particular, this is used to identify the relevant 0->1 transition to determine the drift time and thus the drift radius, as well as the time over threshold (= size of largest island). The drift time used to be determined from the first 0->1 transition instead, which is much less robust for high pile-up. This can change the hit position used in track fits and will thus change the resulting tracks.
- Major clean up of the dEdx tool to remove unused methods and code duplication. Clients can no longer override the settings of the dEdx tool when getting dEdx which allows to remove some redundant parameters from
TrackSummaryTool
.
Merge request reports
Activity
added master label
This merge request affects 5 packages:
- InnerDetector/InDetExample/InDetRecExample
- InnerDetector/InDetRawEvent/InDetRawData
- InnerDetector/InDetRecEvent/InDetPrepRawData
- InnerDetector/InDetRecTools/TRT_ElectronPidTools
- Tracking/TrkTools/TrkTrackSummaryTool
Adding @goetz ,@cgrefe ,@amorley ,@calfayan ,@sroe as watchers
added InnerDetector Tracking review-pending-level-1 labels
This merge request affects 5 packages:
- InnerDetector/InDetExample/InDetRecExample
- InnerDetector/InDetRawEvent/InDetRawData
- InnerDetector/InDetRecEvent/InDetPrepRawData
- InnerDetector/InDetRecTools/TRT_ElectronPidTools
- Tracking/TrkTools/TrkTrackSummaryTool
Adding @goetz ,@cgrefe ,@amorley ,@calfayan ,@sroe as watchers
This merge request affects 5 packages:
- InnerDetector/InDetExample/InDetRecExample
- InnerDetector/InDetRawEvent/InDetRawData
- InnerDetector/InDetRecEvent/InDetPrepRawData
- InnerDetector/InDetRecTools/TRT_ElectronPidTools
- Tracking/TrkTools/TrkTrackSummaryTool
Adding @goetz ,@cgrefe ,@amorley ,@calfayan ,@sroe as watchers
❎ CI Result FAILUREAthena AthSimulation AnalysisBase AthGeneration externals ⭕ ⭕ ✅ ✅ cmake N/A N/A N/A N/A make N/A N/A N/A N/A required tests N/A N/A N/A N/A optional tests N/A N/A N/A N/A ❗ Due to problems in externals build or cmake configuration the job is stopped, results are not available on the ATLAS CI monitor✅ Athena: number of compilation errors 0, warnings 0
✅ AthSimulation: number of compilation errors 0, warnings 0
✅ AnalysisBase: number of compilation errors 0, warnings 0
✅ AthGeneration: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 16832]❎ CI Result FAILURE (hash 2753168b)Athena AthSimulation AnalysisBase AthGeneration externals ✅ ✅ ✅ ✅ cmake ✅ ✅ ✅ ✅ make ⭕ ✅ ✅ ✅ required tests ⭕ ✅ ✅ ✅ optional tests ☁ ✅ ✅ ✅ Full details available on this CI monitor view
⭕ Athena: number of compilation errors 2, warnings 1
✅ AthSimulation: number of compilation errors 0, warnings 0
✅ AnalysisBase: number of compilation errors 0, warnings 0
✅ AthGeneration: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 16831]This merge request affects 7 packages:
- InnerDetector/InDetExample/InDetRecExample
- InnerDetector/InDetRawEvent/InDetRawData
- InnerDetector/InDetRecAlgs/InDetLowBetaFinder
- InnerDetector/InDetRecEvent/InDetPrepRawData
- InnerDetector/InDetRecTools/TRT_ElectronPidTools
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkInDet
- Tracking/TrkTools/TrkTrackSummaryTool
Adding @goetz ,@cgrefe ,@amorley ,@calfayan ,@sroe as watchers
added Derivation label
❎ CI Result FAILURE (hash c9ff916c)Athena AthSimulation AnalysisBase AthGeneration externals ✅ ✅ ✅ ✅ cmake ✅ ✅ ✅ ✅ make ⭕ ✅ ✅ ✅ required tests ⭕ ✅ ✅ ✅ optional tests ☁ ✅ ✅ ✅ Full details available on this CI monitor view
⭕ Athena: number of compilation errors 2, warnings 2
✅ AthSimulation: number of compilation errors 0, warnings 0
✅ AnalysisBase: number of compilation errors 0, warnings 0
✅ AthGeneration: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 16833]❎ CI Result FAILUREAthena AthSimulation AnalysisBase AthGeneration externals ⭕ ⭕ ✅ ✅ cmake N/A N/A N/A N/A make N/A N/A N/A N/A required tests N/A N/A N/A N/A optional tests N/A N/A N/A N/A ❗ Due to problems in externals build or cmake configuration the job is stopped, results are not available on the ATLAS CI monitor✅ Athena: number of compilation errors 0, warnings 0
✅ AthSimulation: number of compilation errors 0, warnings 0
✅ AnalysisBase: number of compilation errors 0, warnings 0
✅ AthGeneration: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 16862]This merge request affects 7 packages:
- InnerDetector/InDetExample/InDetRecExample
- InnerDetector/InDetRawEvent/InDetRawData
- InnerDetector/InDetRecAlgs/InDetLowBetaFinder
- InnerDetector/InDetRecEvent/InDetPrepRawData
- InnerDetector/InDetRecTools/TRT_ElectronPidTools
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkInDet
- Tracking/TrkTools/TrkTrackSummaryTool
Adding @goetz ,@cgrefe ,@amorley ,@calfayan ,@sroe as watchers
❎ CI Result FAILUREAthena AthSimulation AnalysisBase AthGeneration externals ⭕ ⭕ ✅ ✅ cmake N/A N/A N/A N/A make N/A N/A N/A N/A required tests N/A N/A N/A N/A optional tests N/A N/A N/A N/A ❗ Due to problems in externals build or cmake configuration the job is stopped, results are not available on the ATLAS CI monitor✅ Athena: number of compilation errors 0, warnings 0
✅ AthSimulation: number of compilation errors 0, warnings 0
✅ AnalysisBase: number of compilation errors 0, warnings 0
✅ AthGeneration: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 16864]added 1 commit
- 9c12a529 - Put back switch to ignore HT hits for dEdx tool clients
This merge request affects 7 packages:
- InnerDetector/InDetExample/InDetRecExample
- InnerDetector/InDetRawEvent/InDetRawData
- InnerDetector/InDetRecAlgs/InDetLowBetaFinder
- InnerDetector/InDetRecEvent/InDetPrepRawData
- InnerDetector/InDetRecTools/TRT_ElectronPidTools
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkInDet
- Tracking/TrkTools/TrkTrackSummaryTool
Adding @goetz ,@cgrefe ,@amorley ,@calfayan ,@sroe as watchers
❎ CI Result FAILURE (hash 9c12a529)Athena AthSimulation AnalysisBase AthGeneration externals ✅ ✅ ✅ ✅ cmake ✅ ✅ ✅ ✅ make ✅ ✅ ✅ ✅ required tests ⭕ ✅ ✅ ✅ optional tests ✅ ✅ ✅ ✅ Full details available on this CI monitor view
✅ Athena: number of compilation errors 0, warnings 0
✅ AthSimulation: number of compilation errors 0, warnings 0
✅ AnalysisBase: number of compilation errors 0, warnings 0
✅ AthGeneration: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 17002]