Skip to content

TRT_DriftCircleOnTrack. Try to use value for m_globalPosition

Christos Anastopoulos requested to merge ATLAS-EGamma/athena:TRT_DriftCircleOnTrack_avoid_allocations into master
  • Try to do eager inititialization of m_globalPosition.
  • Avoiding lazy-init avoids also dynamic allocations.
  • The idea is set m_globalPosition "eagerly" at the same places where m_detEl is set.

  1. Add function with value return in Straighline surface. So as to be able to have value and no ptr

  2. The ctor used in reconstruction was already eagerly initializing the m_globalposition using the m_detEl passed to it

  3. The other ctor is used in the TPCnv https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/InnerDetector/InDetEventCnv/InDetEventTPCnv/src/InDetRIO_OnTrack/TRT_DriftCircleOnTrackCnv_p1.cxx#0039.

  4. To be able to have a global position after using the TPCnv ctor , the m_delEl needs to be set . This is done in the non-const setValues (called by the cnv tool).

For points 3 and 4 look also !34656 (merged) where similar logic is followed for the Cnv part.

  1. Create a helper for setting the global position as needs >2 lines.

Mentioning @oda

Edited by Christos Anastopoulos

Merge request reports