TrigT1CaloMappingTools+TrigT1CaloToolInterfaces: Make mapping methods const.

Declare IL1CaloMappingTool::mapping() as const. Also update tools to use extends<>.

Further notes:

PpmCoolMappingTool relies on a BeginRun incident, and so is not thread-safe. It should work as long as the run doesn't actually change during processing, but fixing things for the general case will need further work.

PpmCoolOrBuiltinMappingTool should work, but it really should determine its configuration during initialize() rather than during event processing.

Removed caching in PpmMappingTool. Instead, restructure to use arrays rather than std::map.

This merge request affects 2 packages:

• Trigger/TrigT1/TrigT1CaloMappingTools
• Trigger/TrigT1/TrigT1CaloToolInterfaces

Adding @kwhalen ,@afaulkne as watchers

added Trigger master review-pending-level-1 labels

CI Result FAILURE (hash 0fbc05de)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 16890]

Jenkins please retry a build

This merge request affects 2 packages:

• Trigger/TrigT1/TrigT1CaloMappingTools
• Trigger/TrigT1/TrigT1CaloToolInterfaces

Adding @kwhalen ,@afaulkne as watchers

CI Result SUCCESS (hash 0fbc05de)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 17028]

Looks OK

one "complain" I have and I will dare to ask for my info why

class CpmMappingTool : virtual public IL1CaloMappingTool,
                               public AthAlgTool {

becomes

class CpmMappingTool : public extends<AthAlgTool, IL1CaloMappingTool>

I understand the point of the extends , what troubled me lately on lxr is that I 99.9% of the time I know the tool will be AthAlgTool . What I search for are the implementations of an interface and being the second is a bit clunky. I guess one can extend more than one etc ...

Anyhow is not really relevant but is something I have acquired a bit mixed feelings, perhaps I just need to update the way I search in lxr make the string longer and escape characters more ...

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 338044e9

added sweep:ignore label