Beampipe optimisation

The implementation of the beampipe is changed. Assembly volume is now used instead of a union of the central and forward beampipes. It has been tested with 2020-07-15T2139 nightly. ATLASSIM-3773

added Simulation label

Jenkins please retry a build

This merge request affects 1 package:

• AtlasGeometryCommon/BeamPipeGeoModel

Adding @rbianchi as watcher

added Geometry master labels

CI Result FAILURE (hash 77d3508e)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 17316]

The failing tests for the Athena project are all unrelated. The failing test for the AthSimulation project is expected as we would expect these changes to cause a change in the voxelization and hence a change in the simulation output. I.e. the job runs fine, the output just changes slightly.

Hi @yyap ,

what is the status of this MR? Is there more work needed to eventually test this?

Cheers, Michael

Hi @mduehrss, I was under the impression that this still needs to validated by someone. If not, then I think I just need to update the attached reference file and remove the "WIP" label.

Cheers, Yee myHITS.pool.root

Hi @yyap,

would it be possible to add in BeamPipeDetectorTool a configuration option and add an argument to setTagNode: https://gitlab.cern.ch/atlas/athena/-/blob/77d3508e2c962ee4990f64e73b55c3ad815ff036/AtlasGeometryCommon/BeamPipeGeoModel/src/BeamPipeDetectorTool.cxx#L85 such that by default the current beam pipe geometry is created and only with a pre- or postExec change of the configuration your optimized geometry is created? This would greatly simplify validation.

Cheers, John & Michael

added 7871 commits

• 77d3508e...3fc68229 - 7870 commits from branch atlas:master
• 55e6b2c8 - Merge remote-tracking branch 'upstream/master' into beampipeoptimisation

Compare with previous version

added 1 commit

• f44f103a - make beampipe configurable

Compare with previous version

Hi @mduehrss, I've made the changes as you've suggested. So the current default beam pipe is built unless BeamPipeMode is set to "AssemblyBeamPipe" in the pre- or postExec.

Cheers, Yee

unmarked as a Work In Progress

Thanks for this @yyap - from our side it is fine to merge now. Then we can validate separately.

This merge request affects 4 files:

• AtlasGeometryCommon/BeamPipeGeoModel/src/BeamPipeDetectorFactory.cxx
• AtlasGeometryCommon/BeamPipeGeoModel/src/BeamPipeDetectorFactory.h
• AtlasGeometryCommon/BeamPipeGeoModel/src/BeamPipeDetectorTool.cxx
• AtlasGeometryCommon/BeamPipeGeoModel/src/BeamPipeDetectorTool.h

Adding @rbianchi as watcher

added review-pending-level-1 label

CI Result SUCCESS (hash f44f103a)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23544]

CI passed, approving (L1).

added review-approved label and removed review-pending-level-1 label

merged