First step to FastCaloSim migration to HepMC3

In this MR:

• First step to FastCaloSim migration to HepMC3

WARNING: big files (>100K) are found in the changeset

104K in file Simulation/FastShower/FastCaloSim/src/FastShowerCellBuilderTool.cxx

This merge request affects 1 package:

• Simulation/FastShower/FastCaloSim

Adding @jchapman ,@vpascuzz as watchers

added Simulation master review-pending-level-1 labels

CI Result FAILURE (hash 0ef673a4)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 17348]

added 39 commits

• 0ef673a4...bc6f20e4 - 37 commits from branch atlas:master
• 5e9d69d0 - Merge remote-tracking branch 'upstream/master' into HepMC3_FastCaloSim
• 2c8d5477 - Fix compilation

Compare with previous version

WARNING: big files (>100K) are found in the changeset

104K in file Simulation/FastShower/FastCaloSim/src/FastShowerCellBuilderTool.cxx

This merge request affects 1 package:

• Simulation/FastShower/FastCaloSim

Adding @jchapman ,@vpascuzz as watchers

CI Result FAILURE (hash 2c8d5477)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 17353]

Hi @averbyts,
Thanks for making these changes they look good to me, but my one concern would be that replacing:

for(HepMC::GenVertex::particles_out_const_iterator pout=ver->particles_out_const_begin();pout!=ver->particles_out_const_end();++pout) {
      const HepMC::GenParticle* par=*pout;

with

for(auto par: *ver) {

makes the code less clear. Replacing par with par_out in the loop would help.
I know it makes the code more clunky temporarily, but I think that the equivalent of:

#ifdef HEPMC3
    for(auto par_in:ver->particles_in()) {
#else
    const HepMC::GenParticle* par_in=0;
    for(HepMC::GenVertex::particles_in_const_iterator pin=ver->particles_in_const_begin();pin!=ver->particles_in_const_end();++pin) {
      par_in=*pin;
#endif

would be even clearer.
What do you think?
Cheers,
John

added 1 commit

• 970b0caa - Fix compilation

Compare with previous version

Hi @jchapman , did that. Totally makes sense.

Andrii

WARNING: big files (>100K) are found in the changeset

104K in file Simulation/FastShower/FastCaloSim/src/FastShowerCellBuilderTool.cxx

This merge request affects 1 package:

• Simulation/FastShower/FastCaloSim

Adding @jchapman ,@vpascuzz as watchers

CI Result FAILURE (hash 970b0caa)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 17373]

added 1 commit

• d1497e98 - Compile fixes

Compare with previous version

WARNING: big files (>100K) are found in the changeset

104K in file Simulation/FastShower/FastCaloSim/src/FastShowerCellBuilderTool.cxx

This merge request affects 1 package:

• Simulation/FastShower/FastCaloSim

Adding @jchapman ,@vpascuzz as watchers

CI Result FAILURE (hash d1497e98)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 17385]

Jenkins please retry a build

WARNING: big files (>100K) are found in the changeset

104K in file Simulation/FastShower/FastCaloSim/src/FastShowerCellBuilderTool.cxx