Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 143
    • Merge requests 143
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !34888

FIx AGENE-1818

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Giancarlo Panizzo requested to merge gpanizzo/athena:21.6 into 21.6 Jul 18, 2020
  • Overview 2
  • Commits 4
  • Pipelines 1
  • Changes 5

External/Pythia8 and Generators/Pythia8_i were working with the Pythia 8.3 series with two exceptions, which this MR is fixing:

  1. soft qcd processes: Pythia8.3 needs, on top of the share/Pythia8/xmldoc subfolder, also share/Pythia8/pdfdata, which is now properly copied into the installArea by External/Pythia8/CMakeLists.txt

  2. UserHooks: Pythia8.3 changed the internal user hooks pointer from UserHooks* to shared_ptr<UserHooks*>. This must be managed with some care when trying to support both Pythia8.2 and Pythia8.3, which is now done by our interface Pythia8_i

Simple technical tests are passed. Now needs physics validation, out of the scope of this MR.

See https://its.cern.ch/jira/browse/AGENE-1818 G

Edited Jul 18, 2020 by Giancarlo Panizzo
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 21.6