SurfaceUniquePtrT move to TrkEventPrimitives
SurfaceUniquePtrT
move to TrkEventPrimitives
from TrkParticleBase
to be easier to use it in other places in tracking where we use surfaces
Merge request reports
Activity
This merge request affects 2 packages:
- Tracking/TrkEvent/TrkEventPrimitives
- Tracking/TrkEvent/TrkParametersBase
Adding @amorley as watcher
added JetEtmiss Tracking master review-pending-level-1 labels
CI Result FAILURE (hash 5039ad6e)Athena AthSimulation AnalysisBase AthGeneration externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 102, warnings 860
AthSimulation: number of compilation errors 2, warnings 18
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 11, warnings 13
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 17409]This merge request affects 3 packages:
- Tracking/TrkDetDescr/TrkSurfaces
- Tracking/TrkEvent/TrkEventPrimitives
- Tracking/TrkEvent/TrkParametersBase
Adding @amorley as watcher
CI Result FAILURE (hash 302d953b)Athena AthSimulation AnalysisBase AthGeneration externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 17414]LCG update related issue on dict https://its.cern.ch/jira/browse/ATR-21753
build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc8-opt/include/xAODTrigEgamma/versions/TrigPhotonContainer_v1.h:18:1: error: explicit specialization of 'DataVectorBase<xAOD::TrigPhoton_v1>' after instantiation DATAVECTOR_BASE( xAOD::TrigPhoton_v1, xAOD::IParticle ); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc8-opt/include/AthContainers/DataVector.h:640:43: note: expanded from macro 'DATAVECTOR_BASE' #define DATAVECTOR_BASE(T, BASE) \ ^ /build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc8-opt/include/AthContainers/DataVector.h:650:20: note: expanded from macro '\ DATAVECTOR_BASE_FWD' template <> struct DataVectorBase<T>
Edited by Christos Anastopoulosadded review-approved label and removed review-pending-level-1 label
mentioned in commit 4add80ef
added sweep:ignore label