Skip to content

TrigT1TGC: fixes for static thread checker

Frank Winklmeier requested to merge fwinkl/athena:trigt1tgc_threadchecker into master

A first pass to make the package pass the static thread checker:

  • replace MsgStreamMember by inheriting from AthMessaging.
  • remove calls to exit to handle out-of-memory situations (this is really not needed)
  • large amount of const correctness fixes
  • remove static variables or make them const

Unrelated cleanup:

  • rename .hh files to .h.
  • remove some user-defined copy constructors and assignment operators because the compiler-generated ones are just fine

This package still has one remaining problem that should be address by the package authors (@masato, @junpei, @hhibi) in a follow-up MR and that prevents the enabling of the thread checker:

Trigger/TrigT1/TrigT1TGC/src/LVL1TGCTrigger.cxx:190:18: warning: 'const' discarded from expression 'rdo' of type 'const TgcRdo*' within function 'virtual StatusCode LVL1TGCTrigger::LVL1TGCTrigger::execute()'; may not be thread-safe
         TgcRdo * thisRdo = const_cast<TgcRdo *>(rdo);
                  ^~~~~~~
Edited by Frank Winklmeier

Merge request reports