[ATR-21216][ATR-21780] Make EDM creation conditional on one or more chains passing the event

Splits off a new small sequencer inside HLTEndSeq in order to enforce strict algorithm execution ordering and to save CPU for events which do not pass any chains.

New structure (oldJO formalism)

            HLTEndSeq [Seq]  [Concurrent]  [OR]
              TriggerSummaryFinal [Alg]  [n= 0]
              TrigSignatureMoniMT [Alg]  [n= 0]
              HLTFinalizeSeq [Seq]  [Sequential]  [Prompt]
                DecisionSummaryMakerAlg [Alg]  [n= 0]
                HLTAcceptedEventAlgsSeq [Seq]  [Concurrent]  [OR]
                EDMCreatorAlg [Alg]  [n= 0]

HLTFinalizeSeq is [Sequential AND StopOverride=False] meaning that it will short-circuit / exit-early upon getting a single false filter decision from a child.

DecisionSummaryMakerAlg now communicates a filter decision to the scheduler. It only sets its filter status to true if one or more chains pass the event (any stream).

HLTAcceptedEventAlgsSeq is unused, but is somewhere for signatures to put algorithms in the future. It will run only on accepted events.

Finally EDMCreatorAlg is only allowed to run once both DecisionSummaryMakerAlg has finished (w positive filter) and all of HLTAcceptedEventAlgsSeq has finished executing too.

TODO: Needs testing in newJO formalism. Wasn't able to do so today due to crashes elsewhere.

added 1 commit

• add6fd9f - Make EDM creation conditional on one or more chains passing the event, and add...

Compare with previous version

This merge request affects 3 packages:

• Trigger/TrigSteer/TrigOutputHandling
• Trigger/TriggerCommon/TriggerJobOpts
• Trigger/TriggerCommon/TriggerMenuMT

Adding @tamartin ,@rbielski ,@bernius as watchers

added Trigger TriggerMenu master review-pending-level-1 labels

CI Result FAILURE (hash add6fd9f)

	Athena	AthSimulation	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 17605]

Jenkins please retry a build

This merge request affects 3 packages:

• Trigger/TrigSteer/TrigOutputHandling
• Trigger/TriggerCommon/TriggerJobOpts
• Trigger/TriggerCommon/TriggerMenuMT

Adding @tamartin ,@rbielski ,@bernius as watchers

CI Result SUCCESS (hash add6fd9f)

	Athena	AthSimulation	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 17642]

mentioned in merge request !34938 (merged)

mentioned in merge request !34995 (merged)

Let me try to do the same in newJO test in !34938 (merged)

Hi @tbold - please feel free to try the changes here in Trigger/TriggerCommon/TriggerJobOpts/python/TriggerConfig.py in your MR.

Due to the other known newJO issues, I wasn't able to test the changes here in this file.

They should be thematically the same as HLTCFConfig.py for legacy JO

added 1 commit

• b63ab3a7 - Undo changes to TriggerConfig.py, to be applied in MR 34938

Compare with previous version

resolved all threads

This merge request affects 2 packages:

• Trigger/TrigSteer/TrigOutputHandling
• Trigger/TriggerCommon/TriggerMenuMT

Adding @tamartin ,@rbielski ,@bernius as watchers

CI Result SUCCESS (hash b63ab3a7)

	Athena	AthSimulation	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 17680]

added urgent label

Hello, the changes look good to me, the cmake warnings are unrelated. Approving. Cheers - L1

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit d9577613

added sweep:ignore label