Event format meta data

Picking up from the discussion at !33803 (closed)

@akraszna implemented a very nice start to handling xAOD::EventFormat metadata in athenaMT. @gemmeren Pointed out that we should adopt a uniform approach to handling EventStreamInfo and xAOD::EventFormat. This leaves some approaches:

• Write multithreaded service maintaining one shared EventStreamInfo object in a thread-safe manner.
• Maintain a xAOD::EventFormat object for each output stream.
• Something we have not yet thought of Here we choose the second, i.e. maintain a xAOD::EventFormat object for each output stream. That means the key of the xAOD::EventFormat object now is a function of the stream name. Trying to adopt the EventStreamInfo style I went for something like:

AthenaOutputStream(
    name=name,
    HelperTools=[
        CfgMgr.xAODMaker__EventFormatStreamHelperTool(
            name="EventFormatStreamHelper"
            Key='Format{}'.format(name),
        ),
    ],
)

Of course any client looking up xAOD::EventFormat by key will have to adjust for that, as you can see in the read test. How much of a nightmare will this be?

I have not yet included recording and retrieving xAOD::EventFormat though the MetaDataSvc as implemented for EventStreamInfo. Is that desirable @mnowak

As you can see by the hacky approach and the title this is still a construction site and needs cleaning up.

Thoughts?

@tsulaia

Event/xAOD/xAODEventFormatCnv/src/EventFormatStreamHelperTool.cxx

@@ -77,6 +77,8 @@ StatusCode
         std::string typeName;
         if( m_clidSvc->getTypeInfoNameOfID( proxy->clID(),
                                            typeName ).isFailure() ) {
+          // Make sure that nobody else is using @c m_warnedCLIDs right now.
+          std::lock_guard< std::mutex > lock( m_warnedCLIDsMutex );
           // Print a warning if this CLID didn't produce a warning yet:
           if( m_warnedCLIDs.insert( proxy->clID() ).second ) {
             ATH_MSG_WARNING( "Couldn't get type name for CLID = "
@@ -103,6 +105,9 @@ StatusCode
         // Update the metadata object.
         uint32_t hash = 0;
         {
+          // Make sure that nobody else is modifying @c m_ef or @c m_spool
+          // right now.
+          std::lock_guard< std::mutex > lock( m_efMutex );
           // If we already know about this object, then don't bother.
           if( event_format->exists( branchName ) ) {
             continue;