FlavorTagDiscriminants: Fix clang warnings.

Scott Snyderrequested to merge
ssnyder/athena:clang.FlavorTagDiscriminants-20200726 into master
  • Unused typedefs.
  • struct/class mismatch
  • Spurious copy in range for.

Merge request reports