In !34711 (merged), we lifted some of the boundary checking code from InDetTrackHoleSearch into a new tool called InDetBoundaryCheckTool. However, we didn't actually remove the old code in the hole search tool and replace it with calls to the new tool due to configuration errors. Indeed, the hole search tool was being created and configured in several configuration scripts, and we didn't want to break anybody's workflow.
This MR, then, is the follow-up in which we remove the old code in the hole search tool and replace it all by calls to our new tool. In addition, we change the configuration of every single hole search tool define in this repository such that they are compatible with the new architecture.
I validated this MR by comparing it to ac6c952e (nightly/master/2020-07-27T0451) on aiatlas034.cern.ch. A comparison between the resulting ESD files using diffPoolFiles returns that they are identical. In terms of runtime, the time spent in the InDetSiSpTrackFinder drops from 923 milliseconds to 831 milliseconds. I wouldn't necessarily expect this change to have a significant impact on the runtime though, so I think this is just measurement noise.