Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 146
    • Merge requests 146
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !35171

Adapt InDetTrackHoleSearch to use InDetBoundaryCheckTool

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Stephen Nicholas Swatman requested to merge sswatman/athena:refactor/hole_search_use_bounds_check into master Jul 28, 2020
  • Overview 18
  • Commits 9
  • Pipelines 4
  • Changes 17

In !34711 (merged), we lifted some of the boundary checking code from InDetTrackHoleSearch into a new tool called InDetBoundaryCheckTool. However, we didn't actually remove the old code in the hole search tool and replace it with calls to the new tool due to configuration errors. Indeed, the hole search tool was being created and configured in several configuration scripts, and we didn't want to break anybody's workflow.

This MR, then, is the follow-up in which we remove the old code in the hole search tool and replace it all by calls to our new tool. In addition, we change the configuration of every single hole search tool define in this repository such that they are compatible with the new architecture.

I validated this MR by comparing it to ac6c952e (nightly/master/2020-07-27T0451) on aiatlas034.cern.ch. A comparison between the resulting ESD files using diffPoolFiles returns that they are identical. In terms of runtime, the time spent in the InDetSiSpTrackFinder drops from 923 milliseconds to 831 milliseconds. I wouldn't necessarily expect this change to have a significant impact on the runtime though, so I think this is just measurement noise.

Edited Aug 03, 2020 by Stephen Nicholas Swatman
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: refactor/hole_search_use_bounds_check