Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Jira
    • Jira
  • Merge requests 135
    • Merge requests 135
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !35260

[ATR-21353] Add visitedCache to TrigCompositeUtils::findLinks

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Tim Martin requested to merge tamartin/athena:findLinkCaching into master Jul 30, 2020
  • Overview 3
  • Commits 1
  • Pipelines 1
  • Changes 2

Adds a pointer-cache of visited nodes when recursively exploring a trigger navigation DAG.

Before, to fully recursively explore this demo graph starting on a and terminating on i would take 24 hops (a>b b>e e>f f>i e>g g>i e>h h>i a>c c>e e>f f>i e>g g>i e>h h>i a>d d>e e>f f>i e>g g>i e>h h>i).

After, by skipping nodes which have already been visited - this reduces to 12 hops (a>b b>e e>f f>i e>g g>i e>h h>i a>c c>e a>d d>e).

Aim to refactor the "is parent of" checks of egamma code in [ATR-21353] to use findLinks where possible, and hence to benefit from this speed up.

 i
/|\
fgh
\|/
 e
/|\
bcd
\|/
 a
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: findLinkCaching