Skip to content
Snippets Groups Projects

runHLT_standalone: Fix use of message level constants

Merged runHLT_standalone: Fix use of message level constants
rbielski/athena:runhlt-loglvl-constants into master
All threads resolved!
Merged Rafal Bielski requested to merge rbielski/athena:runhlt-loglvl-constants into master
All threads resolved!

Fix unfortunate mistake made in !34445 (merged). For some reason, in the scope where it is used, logging.INFO = 20 is different from Constants.INFO = 3. The comparison protecting overly verbose print-outs was comparing the current printing level to the wrong constant. As a result, a typical HLT athena job log was full of useless information and 20MB large instead of <5MB.

Merge request reports

Pipeline #1845041 passed

Stage: external

    Pipeline passed for 15b9aa0b on rbielski:runhlt-loglvl-constants

    Approval is optional

    Merged by Frank WinklmeierFrank Winklmeier 4 years ago (Aug 4, 2020 1:02pm UTC)

    Merge details

    • Changes merged into master with bbae0bc0.
    • Deleted the source branch.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • Frank Winklmeier
  • Rafal Bielski added 149 commits

    added 149 commits

    Compare with previous version

  • Rafal Bielski resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Trigger/TriggerCommon/TriggerJobOpts
  • ATLAS Robot added review-pending-level-1 label and removed review-approved label

    added review-pending-level-1 label and removed review-approved label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 15b9aa0b)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18248]

  • Tadej Novak
    Tadej Novak @tadej ·
    Developer

    Warning is unrelated. Approving.

    Tadej (L2)

  • Tadej Novak added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Frank Winklmeier merged

    merged

  • Frank Winklmeier mentioned in commit bbae0bc0

    mentioned in commit bbae0bc0

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply