EventInfoTag builder cleanup

This MR cleans EventInfoTagBuilder and makes xAOD::EventInfo mandatory.

As discussed in ATEAM-643 all existing unit tests have been fixed (separate MRs). Other job options might have to be updated in the future by their users. As there were very little tests actually to be fixed, we assume that most of the non-tested configuration is fine.

/cc @gemmeren

added bugfix urgent labels

This merge request affects 1 package:

• Database/AthenaPOOL/OutputStreamAthenaPool

Adding @ssnyder ,@mnowak as watchers

added Database master review-pending-level-1 labels

Thanks. Did you check this fixes the failing tests? Was the WARNING message there before already? If not, will we have reference diffs again?

Will check for references now.

marked as a Work In Progress

changed title from Revert mandatory EventInfo in EventInfoTagBuilder for now to WIP: EventInfoTag builder cleanup

changed the description

removed bugfix urgent labels

The warning message was there before but another one is still introduced. I approved the revert as I do not want to risk more failures. Will provide a proper fix.

Sorry again!

removed review-pending-level-1 label

added 9 commits

• 893681aa...9154a0ed - 8 commits from branch atlas:master
• 3ddbdd3d - Cleanup EventInfoTagBuilder

Compare with previous version

added 1177 commits

• 3ddbdd3d...77d17bf8 - 1176 commits from branch atlas:master
• 624f65fa - Cleanup EventInfoTagBuilder

Compare with previous version

added full-unit-tests label

Jenkins please retry a build

This merge request affects 1 package:

• Database/AthenaPOOL/OutputStreamAthenaPool

Adding @ssnyder ,@mnowak as watchers

CI Result FAILURE (hash 624f65fa)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19381]

unmarked as a Work In Progress

changed the description

Jenkins please retry a build