Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 146
    • Merge requests 146
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !35422

Fixes for SimExoticsTests jobs - ATLASSIM-4663

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged John Derek Chapman requested to merge jchapman/athena:SimExoticsTest_ATLASSIM-4663_master into master Aug 06, 2020
  • Overview 2
  • Commits 2
  • Pipelines 1
  • Changes 3

Follows on from !34869 (merged). Add back imports of units as they are used when specialConfiguration strings are evaluated. Commented these lines, so that they are ignored by the flake8 checks. Fixes ATLASSIM-4663.

While fixing this I noticed that the specialConfiguration variables in Simulation/G4Extensions/Charginos/python/CharginosConfig.py were being multiplied by units (MeV or ns) in the python code, even though they were already being specified with units in the specialConfiguration strings. (Presumably the convention changed, but the python code was not updated.) I've fixed this in master, but fortunately both MeV and ns evaluate to "1", so MC16 samples should be unaffected.

Edited Aug 06, 2020 by John Derek Chapman
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: SimExoticsTest_ATLASSIM-4663_master