Skip to content
Snippets Groups Projects

Update vertex analysis binning, tidy code, reduce INFO output

Merged Mark Sutton requested to merge sutt/athena:rabit into master
All threads resolved!

The vertex analyses were based on the superRoi bject vertex tracking wiyth a lower track multiplicity. This requests updates some of the binning, for this, plus adds protection for incorrectly matched Rois from the TDT feature retrieval until this if fixed, and also downgrades most of the INFO printout to DEBUG

Merge request reports

Pipeline #1854817 passed

Pipeline passed for de5126ca on sutt:rabit

Approval is optional

Merged by Vakhtang TsulaiaVakhtang Tsulaia 4 years ago (Aug 12, 2020 5:43pm UTC)

Merge details

  • Changes merged into master with f82ca9c8 (commits were squashed).
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jason Robert Veatch
  • Jason Robert Veatch
  • Jason Robert Veatch
  • Jason Robert Veatch
  • Jason Robert Veatch
  • Jason Robert Veatch
  • Mark Sutton resolved all threads

    resolved all threads

  • added urgent label

  • Author Developer

    Hi, can this be merged now ? Thanks Mark

  • After addressing the issues, even if that is as simple as explaining why the changes are not necessary, please add the review-pending-level-1 back to ensure a prompt review.

    Following your explanations, the changes are fine. The CI make issue is not related to this MR. Approving.

    Jason (L1)

  • Author Developer

    Thanks Jason

    Cheers Mark

  • mentioned in commit f82ca9c8

  • Please register or sign in to reply
    Loading