Skip to content
Snippets Groups Projects

MuonPrepData: noexcept_moveable for vector optimization

Merged Adam Edward Barton requested to merge abarton/athena:muonprepOpti into master
All threads resolved!

In some places in the code prepData is used directly in a std::vector, without noexcept move operators this causes copying whenever the vector expands. Making the move operators noexcept allows optimization.

I also make minor changes suggested by clang-tidy

cc @ssnyder, I had to make adjustments to CachedUniquePtrT

Edited by Adam Edward Barton

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Christos Anastopoulos
  • Christos Anastopoulos resolved all threads

    resolved all threads

  • Changes look fine to me. Sending on to L2 for a second opinion due to the large number of changes. Clara (L1)

  • added review-approved label and removed review-pending-level-1 label

  • added review-pending-level-2 label and removed review-approved label

  • I don't see any issues, approving this MR. ~Joe (L2)

  • added review-approved label and removed review-pending-level-2 label

  • merged

  • Edward Moyse mentioned in commit 1bf1b996

    mentioned in commit 1bf1b996

  • Please register or sign in to reply
    Loading