add Gaudi::Property, SG::ReadHandleKeyArray for AnalysisBase

The next set of handles/helpers to make AnalysisBase functional in master. SG::ReadHandleKeyArray was essentially copied over from the StoreGate package and modified it for use in AnalysisBase, while Gaudi::Property was essentially rewritten from scratch. Also added some functionality to other handles and added all packages that can now be compiled in AnalysisBase.

As with the other data handles I left all the unused code in the SG::ReadHandleKeyArray for now, commented out. This makes it easier to add more functionality as needed to get the remaining packages functional. The plan is once the migration is complete to go through the remaining commented out code and either make it functional or remove it.

This merge request affects 9 packages:

• Control/AthToolSupport/AsgDataHandles
• Control/AthToolSupport/AsgExampleTools
• Control/AthToolSupport/AsgTools
• PhysicsAnalysis/AnalysisCommon/ParticleJetTools
• Projects/AnalysisBase
• Reconstruction/Jet/JetInterface
• Reconstruction/Jet/JetRec
• Reconstruction/MET/METUtilities
• Reconstruction/RecoTools/IsolationTool

Adding @goetz ,@akraszna ,@krumnack ,@jveatch ,@ssnyder ,@rbianchi as watchers

added Analysis BTagging Build Core JetEtmiss Reconstruction master review-pending-level-1 labels

CI Result FAILURE (hash e439b438)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 3
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18699]

I made some updates that fix the compiler warnings in AnalysisBase, and disabled the failing test for AnalysisBase (it was an Athena-based test and was probably never meant to run in AnalysisBase).

The build error in Athena seems like a transient error, and at any rate unrelated to these changes. The two failing tests in Athena are hopefully unrelated. The actual code changes I made are rather minimal, so I'd be somewhat surprised if that caused any new test failures for Athena.

Not quite sure why the updates don't show up. Hopefully it is just gitlab being slow.

added 4 commits

• 7d647ef0 - fix compilation warning
• 5d86c195 - fix compiler warning
• a4b160aa - fix compiler warning
• 48c19fa1 - disable athena-based test in AnalysisBase

Compare with previous version

This merge request affects 9 packages:

• Control/AthToolSupport/AsgDataHandles
• Control/AthToolSupport/AsgExampleTools
• Control/AthToolSupport/AsgTools
• PhysicsAnalysis/AnalysisCommon/ParticleJetTools
• Projects/AnalysisBase
• Reconstruction/Jet/JetInterface
• Reconstruction/Jet/JetRec
• Reconstruction/MET/METUtilities
• Reconstruction/RecoTools/IsolationTool

Adding @goetz ,@akraszna ,@krumnack ,@jveatch ,@ssnyder ,@rbianchi as watchers

CI Result FAILURE (hash 48c19fa1)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18734]

Jenkins please retry a build

This merge request affects 9 packages:

• Control/AthToolSupport/AsgDataHandles
• Control/AthToolSupport/AsgExampleTools
• Control/AthToolSupport/AsgTools
• PhysicsAnalysis/AnalysisCommon/ParticleJetTools
• Projects/AnalysisBase
• Reconstruction/Jet/JetInterface
• Reconstruction/Jet/JetRec
• Reconstruction/MET/METUtilities
• Reconstruction/RecoTools/IsolationTool

Adding @goetz ,@akraszna ,@krumnack ,@jveatch ,@ssnyder ,@rbianchi as watchers

CI Result SUCCESS (hash 48c19fa1)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18762]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 45493822

added sweep:ignore label