Make xAODTrackingCnv reentrant, remove monitoring and printouts

Make xAODTrackingCnv reentrant. The monitoring is now gone (easier to migrate), but let me know if this is too brutal. My impression is that most of the detailed offline validation comes from diff-root on xAODs and physics validation, neither of which are affected by this change.

Cheers,

Stewart

This merge request affects 1 package:

• Event/xAOD/xAODTrackingCnv

Adding @amorley ,@akraszna as watchers

added EDM master review-pending-level-1 labels

CI Result FAILURE (hash 4934060c)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18715]

Failure likely comes from CI_TEST/CI_TEST_RUNNER: TEST FAILURE: Trigger_athena_MC returned code 65. Waiting on the investigation (see: https://its.cern.ch/jira/browse/ATR-21896). Abhishek (L1)

Jenkins please retry a build

This merge request affects 1 package:

• Event/xAOD/xAODTrackingCnv

Adding @amorley ,@akraszna as watchers

CI Result FAILURE (hash 4934060c)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18769]

Jenkins please retry a build

This merge request affects 1 package:

• Event/xAOD/xAODTrackingCnv

Adding @amorley ,@akraszna as watchers

CI Result FAILURE (hash 4934060c)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18846]

added review-user-action-required label and removed review-pending-level-1 label

Please fix failed tests. A common error that I see in the logs is:

AttributeError: 'xAODMaker__TrackParticleCnvAlg' object has no attribute 'PrintIDSummaryInfo'

Magdalena (L1 shifter)

added 1 commit

• d14b9b5f - Don't set removed PrintIDSummaryInfo

Compare with previous version

This merge request affects 6 packages:

• Event/xAOD/xAODTrackingCnv
• InnerDetector/InDetEventCnv/InDetPrepRawDataToxAOD
• InnerDetector/InDetExample/InDetAlignExample
• InnerDetector/InDetExample/InDetRecExample
• Reconstruction/MuonIdentification/MuonCombinedRecExample
• Trigger/TrigTools/TrigInDetConfig

Adding @goetz ,@sutt ,@amorley ,@wleight ,@nagano ,@sroe ,@mvozak ,@rosati ,@bernius ,@akraszna ,@nkoehler as watchers

added InnerDetector Reconstruction Trigger review-pending-level-1 labels and removed review-user-action-required label

CI Result SUCCESS (hash d14b9b5f)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18939]

At some point we were discussing adding the track monitoring to the xAOD conversion, since this is the only place common to all the tracking instances, so before removing the monitoring from there, could you check with Mat Vozak and John Baines to make sure that this isn't removing any of the code that was needed for that. If it is older monitoring that is no longer used then it could be removed.

Cheers Mark

Hi, originally we wanted to have some online monitoring of tracks in both precision tracking and fast tracking configurations. As both of them are using particle cnv alg at the end we thought this might be a good place where to put (m_trackMonitoringTool). Atm there were just a couple of basic distributions, but some update on variables was planned. I am not sure whether there are already monitorings added to different tracking algs/tools and this one is therefore irrelevant.

OK, in that case looks like you should be able to add it back in when it's ready. It is only one line.

Cheers,

Stewart

Code changes look fine. Waiting for the open discussion above. If everyone agrees with the author's answer, I am happy to approve the MR. Pienpen (L1)