TrigUpgradeTest: delete package
Final steps in the clean-up of the TrigUpgradeTest package:
- Move the
Cosmic.py
job opts and the corresponding test to TrigInDetValidation, FYI @mvozak - Move the
newJOtest.py
job opts to TriggerJobOpts asrunHLT_standalone_newJO.py
, FYI @tbold - Remove a few mentions of the package name across the repository.
- Update two TrigT2CaloCommon unit tests to execute the athena command directly instead of relying on deleted wrapper scripts(A)
- Delete the TrigUpgradeTest package
Closes ATR-21713 and ATR-20514, also relevant to ATR-19150
(A) The two TrigT2CaloCommon unit tests updated here were broken for some time, but the wrapper scripts ignored the failures and always returned code 0. This was definitely not intentional but perhaps it wasn't noticed. Because of this, I commented out the athena command in these tests because the unit test would start (correctly) failing after my changes. Instead, I added a message and a comment saying what needs to be done. The errors in those tests have nothing to do with this MR. FYI @damazio, @tbold
Merge request reports
Activity
This merge request affects 8 packages:
- Trigger/TrigAlgorithms/TrigT2CaloCommon
- Trigger/TrigSteer/DecisionHandling
- Trigger/TrigValidation/TrigInDetValidation
- Trigger/TrigValidation/TrigP1Test
- Trigger/TrigValidation/TrigUpgradeTest
- Trigger/TrigValidation/TrigValTools
- Trigger/TrigValidation/TriggerTest
- Trigger/TriggerCommon/TriggerJobOpts
Adding @sutt ,@joheinri ,@rbielski ,@salderwe ,@okumura ,@nagano ,@jpanduro ,@tamartin ,@hartj ,@bernius ,@damazio ,@mvozak as watchers
added Trigger master review-pending-level-1 labels
CI Result FAILURE (hash c2543180)Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18738]This merge request affects 8 packages:
- Trigger/TrigAlgorithms/TrigT2CaloCommon
- Trigger/TrigSteer/DecisionHandling
- Trigger/TrigValidation/TrigInDetValidation
- Trigger/TrigValidation/TrigP1Test
- Trigger/TrigValidation/TrigUpgradeTest
- Trigger/TrigValidation/TrigValTools
- Trigger/TrigValidation/TriggerTest
- Trigger/TriggerCommon/TriggerJobOpts
Adding @sutt ,@joheinri ,@rbielski ,@salderwe ,@okumura ,@nagano ,@jpanduro ,@tamartin ,@hartj ,@bernius ,@damazio ,@mvozak as watchers
CI Result FAILURE (hash c2543180)Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18759]This merge request affects 8 packages:
- Trigger/TrigAlgorithms/TrigT2CaloCommon
- Trigger/TrigSteer/DecisionHandling
- Trigger/TrigValidation/TrigInDetValidation
- Trigger/TrigValidation/TrigP1Test
- Trigger/TrigValidation/TrigUpgradeTest
- Trigger/TrigValidation/TrigValTools
- Trigger/TrigValidation/TriggerTest
- Trigger/TriggerCommon/TriggerJobOpts
Adding @sutt ,@joheinri ,@rbielski ,@salderwe ,@okumura ,@nagano ,@jpanduro ,@tamartin ,@hartj ,@bernius ,@damazio ,@mvozak as watchers
CI Result SUCCESS (hash c2543180)Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18861]added review-approved label and removed review-pending-level-1 label
mentioned in commit 293f2915
added sweep:ignore label