Skip to content
Snippets Groups Projects

Remove documentation particles from truth record

Merged Mark Sutton requested to merge sutt/athena:fsn into master
1 unresolved thread

Some duplictated "documentation" particles with slightly different parameters.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
4 4 ** @author mark sutton
5 5 ** @date Sun 2 Nov 2014 11:10:06 CET
6 6 **
7 7 ** Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
  • Hi Mark, sorry to be a pain, but you are supposed to start each file with the copyright in exactly the following format:

    /*
      Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
    */

    We've not run the scripts for a while, but when we do, this will fail.

  • Author Developer

    Why does the copyright have to be first 3 lines of the file ? and exactly in that format ? Surely just checking for the relevant string and the doing a find and replace for the year should be enough ? I can imaging this would only take about 3 lines for a script. I have a lot of code that uses this format, @author, @date etc for doxygen. In principle even the copyright line itself should really be @copyright. It is not realistic that I go through all the files I have ever written replacing all the headers in this way.

  • Please register or sign in to reply
  • Reviewed. Looks fine, except for a comment about copyright. Since this is urgent, I can merge without waiting for this fix, but @sutt can you please fix it in the future?

    https://atlassoftwaredocs.web.cern.ch/guides/MR_reviewers/#checklist-for-reviewing-a-merge-request

    Edited by Edward Moyse
  • added review-approved label and removed review-pending-level-1 label

  • Edward Moyse resolved all threads

    resolved all threads

  • Edward Moyse mentioned in commit 34e67be0

    mentioned in commit 34e67be0

  • merged

  • Please register or sign in to reply
    Loading