Remove documentation particles from truth record
Some duplictated "documentation" particles with slightly different parameters.
Merge request reports
Activity
added Trigger master review-pending-level-1 labels
CI Result FAILURE (hash 775dd5c8)Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18805]No Idea even why this "required DataQuality" test says that it has failed, as it does seem to actually be reporting any actual errors that I could see.
However, in any case the code in this merge request should not affect any of the data quality tests run in athena, so the problem will in any case, be unrelated to this merge request.
Mark
Edited by Mark Sutton CI Result SUCCESS (hash 7c2fcd0a)Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18804]4 4 ** @author mark sutton 5 5 ** @date Sun 2 Nov 2014 11:10:06 CET 6 6 ** 7 7 ** Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration Why does the copyright have to be first 3 lines of the file ? and exactly in that format ? Surely just checking for the relevant string and the doing a find and replace for the year should be enough ? I can imaging this would only take about 3 lines for a script. I have a lot of code that uses this format, @author, @date etc for doxygen. In principle even the copyright line itself should really be @copyright. It is not realistic that I go through all the files I have ever written replacing all the headers in this way.
Reviewed. Looks fine, except for a comment about copyright. Since this is urgent, I can merge without waiting for this fix, but @sutt can you please fix it in the future?
https://atlassoftwaredocs.web.cern.ch/guides/MR_reviewers/#checklist-for-reviewing-a-merge-request
Edited by Edward Moyseadded review-approved label and removed review-pending-level-1 label
mentioned in commit 34e67be0
added sweep:ignore label