Update of PT in ID Trig configuration
The goal of this MR is to simplify the configuration of the ID Trig precision tracking, make it more readable and at the same time port specific settings of the alg/tools from Run2.
New structure of the code has been adapted (atm only for ambiguity solving stage) This structure follows few points:
- New Signature ConfigurationSetting is being adapted (initiated by @sutt)
- This configuration is set based on the name of the signature (muonLate, tauIso, tauTrk etc)
- Configuration separates between Fast tracking and Precision tracking setting where each one has specific version of cuts and flags (Note! These are not replacing InDetTrigFlags)
- PT Algorithms/Tools are wrapped in the builder freefunctions.
- These builder classes only require name and the configuration
- They set relevant parameters and load necessary subtools hopefully in a readable way
-
Some of the tools are already preconfigured in RecLoadTools and retrieved using getter freefunctions to differentiate from builders that are instantiated from as scratch.
-
MR also contains few fixes in the configuration of tools and adapting some changes in input parameter based on the signature
-
Eventually TrigFastTrackFinder instances should also get new config as input parameter and resolve any tracking cut setting from it.
-
Changes to TRT will be addressed in a different MR
Merge request reports
Activity
added 1 commit
- 2b61da0b - builder fix, employing more getters, adapting config to FTF, atm not...
added 1107 commits
-
2b61da0b...77d17bf8 - 1104 commits from branch
atlas:master
- b0fc4998 - Switching builder classes to free functions, getters are now for fetching...
- eed86033 - fix collections
- 900a1da6 - Merge branch 'master' of https://gitlab.cern.ch:8443/atlas/athena into idtrig-config
Toggle commit list-
2b61da0b...77d17bf8 - 1104 commits from branch
added 1 commit
- b05d3399 - making consistent collection nomenclature in the slice setting
added 1 commit
- a3c8bdbb - adapting ID Trig configuration to signatures
added 1 commit
- 30c4c473 - Changing IDTrig signature configuration to contain both Fast & precision...
added 1254 commits
-
30c4c473...9a50865e - 1253 commits from branch
atlas:master
- c509f2ee - resolve merge conflicts with master
-
30c4c473...9a50865e - 1253 commits from branch
This will probably fail on references, but we expect this to be changed. Also There is a new !36431 (merged) in place with changes that are not included in here yet. But if I understand correctly, from ID Trig config side only require commenting out ScoreProcessorTool which can be done easily
Edited by Matous Vozakadded InnerDetector Trigger TriggerMenu master labels
CI Result FAILURE (hash c509f2ee)Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 2
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20522]added 1 commit
- 75b5e422 - Adding back remapping to FTF, fix tau IDTrig FT stage
CI Result FAILURE (hash 75b5e422)Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 2
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20550]added 48 commits
-
75b5e422...5cadef22 - 47 commits from branch
atlas:master
- 931b3b89 - merge with master, adapt changes of new MR with disabling NN in ambiguity solving stage
-
75b5e422...5cadef22 - 47 commits from branch