Skip to content

Refactor track parameter calculation in GlobalChi2Fitter

Stephen Nicholas Swatman requested to merge sswatman/athena:refactor/gx2f_calc_params into master

This merge request serves as a code clean-up attempt for the GlobalChi2Fitter::calculateTrackParameters. I am working on related changes to this method, but existing technical debt in the form of high code duplication and low readability make this more difficult. The contributions of this merge request to help this issue are:

  1. Deduplication of the number of call sites to the propagator, and lifting them into a separate helper method.
  2. Clearer memory ownership model through the use of smart pointers.

As of this merge request, the actual fitting part of GlobalChi2Fitter (not the track preprocessing part) is now free of manual memory management in the form of new and delete: all the memory is now managed through RAII.

I've validated this merge request against the nightly/master/2020-08-23T2101 nightly, and I have not observed any significant changes in output (via diffPoolFiles) or CPU performance (via pmon).

Merge request reports