Skip to content

L1TopoMenu: Fix move operations

Adam Edward Barton requested to merge abarton/athena:speedup into master

Various useful move operations were defined for L1TopoMenu but clang-tidy said they were not being used properly due to class rules.

/ab/buffer/athena/Trigger/TrigT1/L1Topo/L1TopoConfig/Root/L1TopoMenu.cxx:28:18: warning: passing result of std::move() as a const reference argument; no move will actually happen [performance-move-const-arg]
   m_topoconfig( std::move(o.m_topoconfig) ),
                 ^~~~~~~~~~              ~
/ab/buffer/athena/Trigger/TrigT1/L1Topo/L1TopoConfig/Root/L1TopoMenu.cxx:29:18: warning: passing result of std::move() as a const reference argument; no move will actually happen [performance-move-const-arg]
   m_outputlist( std::move(o.m_outputlist) )

I make adjustments so they are.

Also follow some clang-tidy suggestions about string searching

cc @stelzer

Edited by Adam Edward Barton

Merge request reports