TagEvent+LArSimEvent: Fix cppcheck warnings.

Pass class instances by const reference, not by value.

Prefer to use an initializer list to initializing within a ctor body.

Prefer preincrement to postincrement for iterators.

Also use emplace_back.