Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 146
    • Merge requests 146
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !36037

Fixing check for compatibility between release and jet collection name

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Lars Rickard Strom requested to merge lstroem/athena:21.2-fixDerviationCheckForTaggedJetCollection into 21.2 Aug 31, 2020
  • Overview 4
  • Commits 1
  • Pipelines 1
  • Changes 1

The compatibility check failed for release numbers above 99 due to simple string comparison (did not properly compare two-digits release numbers with three-digits needed for releases 21.2.100 and above). This caused runtime error incorrectly stating that the configured release was older than 21.2.72.0. This patch corrects for that by instead comparing the release numbers as integers. An informative message stating the release number read from the sample meta data was also added to the INFO output.

I've tested the behaviour after the proposed change with 21.2.102.0 and it solves the problem reported above.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 21.2-fixDerviationCheckForTaggedJetCollection