Skip to content
Snippets Groups Projects

Reformat GlobalChi2Fitter CMakeLists.txt

Merged Stephen Nicholas Swatman requested to merge sswatman/athena:format/gx2f_cmake into master
All threads resolved!

The existing formatting of this file is somewhat messy and has some extremely long lines which are not very readable to humans and also confusing for version control systems, as the entire line needs to be changed to modify one single element of the list. This commit changes the formatting of the CMakeLists.txt file to be a lot neater and easier to process for VCS. The actual contents of the file are not changed, and the end result should be identical.

This is an extremely minor merge request.

Edited by Stephen Nicholas Swatman

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • This merge request affects 1 package:

    • Tracking/TrkFitter/TrkGlobalChi2Fitter

    Adding @amorley as watcher

  • :negative_squared_cross_mark: CI Result FAILURE (hash 071d98c9)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :o: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :o: AthGeneration: number of compilation errors 1, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19788]

  • The HepMC3 was not found. Let's try another rebuild, hopefully it's temporary

  • Jenkins please retry a build

    Edited by Johannes Junggeburth
  • Stephen Nicholas Swatman marked as a Work In Progress

    marked as a Work In Progress

  • Stephen Nicholas Swatman changed the description

    changed the description

  • Removing review-pending-level-1 as MR marked as WIP. Cheers, L1

  • added 3 commits

    • 54dbdf63 - Remove outdated call to atlas_depends_on_subdirs
    • 08516141 - Remove unused dependencies on CHEP and ROOT
    • c0c3b0d5 - Remove outdated atlas_install_headers command

    Compare with previous version

  • resolved all threads

  • Stephen Nicholas Swatman unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Made a few changes to bring the file in line with modern Athena CMake conventions. We'll see what the CI thinks.

  • This merge request affects 1 package:

    • Tracking/TrkFitter/TrkGlobalChi2Fitter

    Adding @amorley as watcher

  • :white_check_mark: CI Result SUCCESS (hash c0c3b0d5)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19845]

  • All seems fine, approving. Cheers, L1

  • added review-approved label and removed review-pending-level-1 label

  • merged

  • Walter Lampl mentioned in commit 486f5975

    mentioned in commit 486f5975

  • Please register or sign in to reply
    Loading