TrigOutputHandling: Migrate to IOptionsSvc

Migrate HLTResultMTMaker and TriggerEDMSerialiserTool to the new IOptionsSvc interface. No change in functionality. The parsing works slightly different now and in some cases we can just rely on the default value of IOptionsSvc::get for non-existent properties (e.g. when running offline).

Also apply similar changes to the legacy RandomScaler (this code is really not used anymore and will eventually be deleted) and delete some unused IJOptionsSvc.h includes in trigger monitoring packages.

cc @rbielski @wiedenma

This merge request affects 2 packages:

• Trigger/TrigSteer/TrigOutputHandling
• Trigger/TrigSteer/TrigSteering

Adding @tamartin ,@rbielski as watchers

added Trigger master review-pending-level-1 labels

changed the description

added 1 commit

• 76d988de - TrigMonitoring: Remove unused IJobOptionsSvc includes

Compare with previous version

WARNING: big files (>100K) are found in the changeset

176K in file Trigger/TrigMonitoring/TrigMuonMonitoring/src/CommonMon.cxx

116K in file Trigger/TrigMonitoring/TrigBphysMonitoring/src/HLTXAODBphysMonTool.cxx

184K in file Trigger/TrigMonitoring/TrigTauMonitoring/src/HLTTauMonTool.cxx

This merge request affects 9 packages:

• Trigger/TrigMonitoring/TrigBjetMonitoring
• Trigger/TrigMonitoring/TrigBphysMonitoring
• Trigger/TrigMonitoring/TrigHLTMonitoring
• Trigger/TrigMonitoring/TrigMinBiasMonitoring
• Trigger/TrigMonitoring/TrigMuonMonitoring
• Trigger/TrigMonitoring/TrigSteerMonitor
• Trigger/TrigMonitoring/TrigTauMonitoring
• Trigger/TrigSteer/TrigOutputHandling
• Trigger/TrigSteer/TrigSteering

Adding @ademaria ,@cvarni ,@carquin ,@ebergeas ,@tamartin ,@suyogs ,@malconad ,@sekula ,@rbielski ,@enagy as watchers

added DQ JetEtmiss Tau labels

CI Result SUCCESS (hash 76d988de)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19835]

All looks fine, approving. Cheers, L1

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 38fb9ea1

added sweep:ignore label

Thanks @fwinkl, the changes look good to me though I haven't used the new interface myself yet. Did you test this by running with DEBUG level and seeing the corresponding log messages when the options are read? I would also test this by running test_trigP1_v1Dev_missingROBs_build.py but with forceEnableAllChains=True and seeing if we run into this warning (as we should):
https://gitlab.cern.ch/atlas/athena/-/blob/76d988de7c4bea8ebe01a8367bd31803dc3452cf/Trigger/TrigSteer/TrigOutputHandling/src/HLTResultMTMaker.cxx#L168

Maybe I should actually make this part of that test.

mentioned in merge request !36223 (merged)

resolved all threads