PileUp digitization new configuration
Migrate a chunk of PileUp digitization to new config.
Add PileUpConfigNew, MCTruthSimAlgsConfigNew and RunDependentConfigNew, using ComponentAccumulator configuration.
Add various flags under Digitization.PU.
Add DigitizationPUConfigNew_test.py
to test. This checks that parts of the new configuration code can run, but is not yet a runnable configuration.
Large test setup data are imported from a _setup.py file.
Merge request reports
Activity
added NewConfig label
added Digitization Simulation master review-pending-level-1 labels
CI Result SUCCESS (hash 34e17bfc)Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19952]- Resolved by Rupert Tombs
- Resolved by Rupert Tombs
- Resolved by Rupert Tombs
- Resolved by Rupert Tombs
- Resolved by Rupert Tombs
- Resolved by Rupert Tombs
Overall this looks good. I would just prefer that "plain" functions - functions not returning an accumulator - start lowercase.
Dropped NewMerge* in MCTruthSimAlgsConfigNew on the suggestion of @jchapman .
CI Result SUCCESS (hash d97dab61)Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19968] CI Result SUCCESS (hash af5aa2c8)Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19973]added review-pending-level-2 label and removed review-pending-level-1 label