ATLASRECTS-5666: Migration of JetFitter package to a modularised version in AthenaMT
Description: A new modularised version of the package tested in 21.2. This is the migration to AthenaMT The code runs in both the split and usual b-tagging configuration as defined in https://gitlab.cern.ch/atlas/athena/-/blob/master/PhysicsAnalysis/JetTagging/JetTagAlgs/BTagging/python/BTagRun3Config.py
There are several differences between the 21.2 and the master versions, due to the different environments. Configuration python files are provided in the BTagging/python folder, while keeping (for the time being?) the old JetFitter configuration files.
Tagging @cpollard, @sanmay, @cschiavi, @vdao , @dguest and @guirriec.
Jira: ATLASRECTS-5666
Merge request reports
Activity
added Squash commits label
I managed to write down some configuration files for the new JetFitter code and run it without crashing. Can you carefully take a look at the code, in particular the python code?
I still have to do some physics validation. How can I run on ESD and produce AODs in order to compare JetFitter output?
An additional thing: I see that InDetJetFitterVxFinder was already present in 21.2 before the code restructuring, yet I don't see where in the code it is used. Is this expected? Did I miss it?
Cheers, C.
added Analysis BTagging Derivation InnerDetector JetEtmiss master labels
Athena AthSimulation AthGeneration AnalysisBase externals 
cmake make 
required tests optional tests Full details available on this CI monitor view
added 3 commits
-
Hi @guirriec , I have uploaded a first attempt to write and old-style JO. However, the code has problem during execution with the following error:
RAWtoESD 13:52:29 Py:ConfigurableDb WARNING : Class Trk::FullPerigeeLinearizedTrackFactory not in database RAWtoESD 13:52:29 Py:PropertyProxy ERROR SequentialVertexFitter.LinearizedTrackFactory: Configurable Trk::FullPerigeeLinearizedTrackFactory is not a ConfigurableAlgTool RAWtoESD 13:52:29 Shortened traceback (most recent user call last): RAWtoESD 13:52:29 File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/master_Athena_x86_64-centos7-gcc8-opt/2020-09-16T2101/Athena/22.0.18/InstallArea/x86_64-centos7-gcc8-opt/jobOptions/RecJobTransforms/skeleton.RAWtoESD_tf.py", line 202, in <module> RAWtoESD 13:52:29 else: include( "RecExCommon/RecExCommon_topOptions.py" ) RAWtoESD 13:52:29 File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/master_Athena_x86_64-centos7-gcc8-opt/2020-09-16T2101/Athena/22.0.18/InstallArea/x86_64-centos7-gcc8-opt/jobOptions/RecExCommon/RecExCommon_topOptions.py", line 631, in <module> RAWtoESD 13:52:29 include ("RecExCommon/CombinedRec_config.py") RAWtoESD 13:52:29 File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/master_Athena_x86_64-centos7-gcc8-opt/2020-09-16T2101/Athena/22.0.18/InstallArea/x86_64-centos7-gcc8-opt/jobOptions/RecExCommon/CombinedRec_config.py", line 131, in <module> RAWtoESD 13:52:29 treatException("Could not set up btagging reconstruction") RAWtoESD 13:52:29 File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/master_Athena_x86_64-centos7-gcc8-opt/2020-09-16T2101/Athena/22.0.18/InstallArea/x86_64-centos7-gcc8-opt/jobOptions/RecExCommon/CombinedRec_config.py", line 129, in <module> RAWtoESD 13:52:29 protectedInclude( "BTagging/BTagging_jobOptions.py") RAWtoESD 13:52:29 File "/afs/cern.ch/user/c/cvarni/work/Convenership/AthenaMT/MigrateJF/build/x86_64-centos7-gcc8-opt/jobOptions/BTagging/BTagging_jobOptions.py", line 64, in <module> RAWtoESD 13:52:29 btagger = ConfInstance.setupJetBTaggerAlg(ToolSvc, jet) #The [:-4] is not needed here; this function automatically removes trailing 'jets' or 'Jets'. RAWtoESD 13:52:29 File "/afs/cern.ch/user/c/cvarni/work/Convenership/AthenaMT/MigrateJF/build/x86_64-centos7-gcc8-opt/python/BTagging/BTaggingConfiguration.py", line 415, in setupJetBTaggerAlg RAWtoESD 13:52:29 btagger = self.setupJetBTaggerAlgs(ToolSvc, [JetCollection,], topSequence, Verbose, options, TaggerList, SetupScheme) RAWtoESD 13:52:29 File "/afs/cern.ch/user/c/cvarni/work/Convenership/AthenaMT/MigrateJF/build/x86_64-centos7-gcc8-opt/python/BTagging/BTaggingConfiguration.py", line 505, in setupJetBTaggerAlgs RAWtoESD 13:52:29 thisSecVtxTool = self.setupSecVtxTool('SecVx'+self.GeneralToolSuffix(), jetcol, ToolSvc, Verbose, objs=objs) RAWtoESD 13:52:29 File "/afs/cern.ch/user/c/cvarni/work/Convenership/AthenaMT/MigrateJF/build/x86_64-centos7-gcc8-opt/python/BTagging/BTaggingConfiguration.py", line 1410, in setupSecVtxTool RAWtoESD 13:52:29 newJetFitterVxFinder = toolNewJetFitterVxFinder_SV('JFVxFinder') RAWtoESD 13:52:29 File "/afs/cern.ch/user/c/cvarni/work/Convenership/AthenaMT/MigrateJF/build/x86_64-centos7-gcc8-opt/python/BTagging/BTaggingConfiguration_NewJetFitterTrigCollection.py", line 992, in toolNewJetFitterVxFinder_SV RAWtoESD 13:52:29 return InDet__InDetImprovedJetFitterVxFinder(**options) RAWtoESD 13:52:29 File "/afs/cern.ch/user/c/cvarni/work/Convenership/AthenaMT/MigrateJF/build/x86_64-centos7-gcc8-opt/python/InDetSecVxFinderTool/InDetSecVxFinderToolConf.py", line 51, in __init__ RAWtoESD 13:52:29 setattr(self, n, v) RAWtoESD 13:52:29 File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/master_Athena_x86_64-centos7-gcc8-opt/sw/lcg/releases/LCG_98python3/Python/3.7.6/x86_64-centos7-gcc8-opt/lib/python3.7/copy.py", line 161, in deepcopy RAWtoESD 13:52:29 y = copier(memo) RAWtoESD 13:52:29 File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/master_Athena_x86_64-centos7-gcc8-opt/sw/lcg/releases/LCG_98python3/Python/3.7.6/x86_64-centos7-gcc8-opt/lib/python3.7/copy.py", line 161, in deepcopy RAWtoESD 13:52:29 y = copier(memo) RAWtoESD 13:52:29 RAWtoESD 13:52:29 RuntimeError: SequentialVertexFitter.LinearizedTrackFactory: Default configurable for class Trk::FullPerigeeLinearizedTrackFactory not found in ConfigurableDb.CfgDb RAWtoESD 13:52:29 RAWtoESD 13:52:29 Py:Athena INFO leaving with code 8: "an unknown exception occurred"Do you have further suggestions?
C.
added 2 commits
-
Hi, thanks for your help @guirriec. I have now running code. I'll now do some validation test, but in the meantime let's see what the CI says
-
Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view