Jet/MET updates for R22 AnalysisBase

This makes a few updates which are needed to build AnalysisBase in release 22 (see ATLASG-1549), particularly the Jet/MET analysis algorithms. Changes are:

• Added Jet and MET analysis algorithm packages to AnalysisBase.
• JetCalibrationAlg now uses the new jet calibration interface. No preselection or out-of-validity handling is needed, so these are removed.
• METHelpers.h has been reinstated, for functions like buildMETSum(...). These had been moved into METMaker and METRebuilder, but had no dependence on the actual classes and are more useful to have independently. I've also propagated this to other packages which were using the class-based functions.
• The handling of MissingETAssociationMap has been updated to use our release 22 interface with the new helper class in METMakerAlg.
• METSignificance has been ported from release 21. The option for Run-1-style handling of the JER has been removed, as it was obsolete. WIP: I'm still having some trouble getting this to compile properly as it introduces several new dependencies. In particular I can't seem to get it to find (at least) ElectronPhotonFourMomentumCorrection/​EgammaCalibrationAndSmearingTool.h despite including that package in CMakeLists.txt. Generally I wouldn't want to include a concrete tool header like that, but it contains a needed function which just lives in the xAOD namespace for some reason (xAOD::get_eta_calo(...)).
• Made combinedP4FromRecoTaus::getCaloResolution(...) public in tauRecTools, as it's required for the MET significance calculation. It was public in the past, and presumably someone changed it not knowing there was an external dependence.

@krumnack - Maybe you want to take over from here, since you can probably figure out the remaining dependency issues more easily than me (or at least point out the issue, as I'm a bit stumped)? I've just been attempting to compile it in the current Athena (as opposed to AB) since METUtilities is also needed there.

Tagging also @khoo, @sawyer, @cdelitzs, @sschramm (and @mswiatlo since he's taking over for Steven soon) for their awareness.

Jenkins please retry a build

Let me see what the CI says. I may have better comments then.

This merge request affects 6 packages:

• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/MetAnalysisAlgorithms
• PhysicsAnalysis/JetMissingEtID/JetMissingEtTagTools
• PhysicsAnalysis/JetMissingEtID/MissingEtDQA
• Reconstruction/MET/METInterface
• Reconstruction/MET/METUtilities

Adding @goetz ,@krumnack ,@tadej ,@pagessin as watchers

added Analysis JetEtmiss Reconstruction master labels

CI Result FAILURE (hash 8252f8dd)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 2, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 1, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20776]

Turns out the issue with resolving the Egamma tool was actually due to an invisible non-ASCII character that somehow snuck its way into the include line (probably came from me copying that line from a web-based repo browser). Working version hopefully inbound soon...

added 1 commit

• d1dcf4d3 - Fix dependency issues

Compare with previous version

changed the description

Hi @wbalunas,

I made one minor technical comment, but apart from that I don't see a reason not to remove the WIP status and try to get this into the release.

Though if the MetAnalysisAlgorithms and JetAnalysisAlgorithms packages now actually compile in AnalysisBase, you should update the package_filters.txt file accordingly, by removing these two lines: https://gitlab.cern.ch/atlas/athena/-/blob/master/Projects/AnalysisBase/package_filters.txt#L11-12

This may lead to the unit tests failing in CI. Either fix them or comment them out in the CMakeLists.txt files, and add a comment that these unit tests are temporarily disabled and need to be fixed as part of the migration from 21.2 to master.

Cheers, Nils

PS: If you don't want to mess with the package_filters.txt I will take care of that once this gets merged, but if you could handle that it may streamline things and be more efficient.

added 1 commit

• 734a8ac6 - Remove obsolete CMake declarations

Compare with previous version

resolved all threads

added 2 commits

• 45638753 - MET updates for AB compatibility
• 39cd2a1e - Add Jet/MET analysis algs to AnalysisBase

Compare with previous version

unmarked as a Work In Progress

changed the description

This merge request affects 8 packages:

• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/MetAnalysisAlgorithms
• PhysicsAnalysis/JetMissingEtID/JetMissingEtTagTools
• PhysicsAnalysis/JetMissingEtID/MissingEtDQA
• Projects/AnalysisBase
• Reconstruction/MET/METInterface
• Reconstruction/MET/METUtilities
• Reconstruction/tauRecTools

Adding @goetz ,@martindl ,@krumnack ,@xiaozhon ,@pagessin ,@akraszna ,@adbailey ,@tadej ,@rbianchi as watchers

added Build Tau review-pending-level-1 labels

Thanks for the suggestion @krumnack - I've gone ahead and gotten it to compile in AnalysisBase as well, so I've added those two packages back into the build for that now. I'll see what needs updating in the CI tests when they finish here and then take a look at that.

CI Result FAILURE (hash 39cd2a1e)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20837]