enable PhotonVertexSelection package in AnalysisBase + fixes for MacOS

While (most of) the problems with the package were resolved a while back, it was never enabled in the AnalysisBase build. Done now. This also required removing some out-dated entries from the dictionary.

I also fixed the compilation errors on MacOS (which hopefully doesn't break the build elsewhere). The were some includes that needed to be added, and an extra root library linked in one place.

cc @okiverny @akraszna

This merge request affects 4 packages:

• Control/RootUtils
• PhysicsAnalysis/ElectronPhotonID/PhotonVertexSelection
• Projects/AnalysisBase
• Reconstruction/tauRecTools

Adding @goetz ,@martindl ,@krumnack ,@xiaozhon ,@akraszna ,@adbailey ,@ssnyder ,@rbianchi as watchers

added Analysis Build Core Egamma Reconstruction Tau master review-pending-level-1 labels

CI Result FAILURE (hash 14c0cd23)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20871]

added 1 commit

• 824fd6f7 - disable failing unit test

Compare with previous version

This merge request affects 4 packages:

• Control/RootUtils
• PhysicsAnalysis/ElectronPhotonID/PhotonVertexSelection
• Projects/AnalysisBase
• Reconstruction/tauRecTools

Adding @goetz ,@martindl ,@krumnack ,@xiaozhon ,@akraszna ,@adbailey ,@ssnyder ,@rbianchi as watchers

CI Result SUCCESS (hash 824fd6f7)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20875]

I am not sure we should disable the test. It only requires adding some parenthesis on the print statement to make it python 3 friendly. Can this be easily fixed or is there more to it?

added review-user-action-required label and removed review-pending-level-1 label

added 3 commits

• 12a81c0c - update to python 3
• 406cbf7c - undo fix for MacOS
• 01f0b8ab - readd and fix instantiation of setProperty

Compare with previous version

This merge request affects 4 packages:

• Control/RootUtils
• PhysicsAnalysis/ElectronPhotonID/PhotonVertexSelection
• Projects/AnalysisBase
• Reconstruction/tauRecTools

Adding @goetz ,@martindl ,@krumnack ,@xiaozhon ,@akraszna ,@adbailey ,@ssnyder ,@rbianchi as watchers

added review-pending-level-1 label and removed review-user-action-required label

resolved all threads

added 1 commit

• 520b3f17 - reenable failing test

Compare with previous version

This merge request affects 4 packages:

• Control/RootUtils
• PhysicsAnalysis/ElectronPhotonID/PhotonVertexSelection
• Projects/AnalysisBase
• Reconstruction/tauRecTools

Adding @goetz ,@martindl ,@krumnack ,@xiaozhon ,@akraszna ,@adbailey ,@ssnyder ,@rbianchi as watchers

CI Result SUCCESS (hash 01f0b8ab)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20897]

CI Result FAILURE (hash 520b3f17)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20902]

added 1 commit

• 26bb47b8 - add more dictionary invocations

Compare with previous version

This merge request affects 4 packages:

• Control/RootUtils
• PhysicsAnalysis/ElectronPhotonID/PhotonVertexSelection
• Projects/AnalysisBase
• Reconstruction/tauRecTools

Adding @goetz ,@martindl ,@krumnack ,@xiaozhon ,@akraszna ,@adbailey ,@ssnyder ,@rbianchi as watchers

CI Result FAILURE (hash 26bb47b8)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20910]

added 1 commit

• 75d905ca - one more try on loading dictionaries

Compare with previous version

This merge request affects 4 packages:

• Control/RootUtils
• PhysicsAnalysis/ElectronPhotonID/PhotonVertexSelection
• Projects/AnalysisBase
• Reconstruction/tauRecTools

Adding @goetz ,@martindl ,@krumnack ,@xiaozhon ,@akraszna ,@adbailey ,@ssnyder ,@rbianchi as watchers

CI Result FAILURE (hash 75d905ca)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20919]

The test failing is the PhotonVertexSelection_PhotonVertexSelection_test_ctest

AttributeError: <namespace cppyy.gbl.xAOD at 0x49b7e60> has no attribute 'TruthParticleContaniner'. Full details:
  type object 'xAOD' has no attribute 'TruthParticleContaniner'
  'xAOD::TruthParticleContaniner' is not a known C++ class
  'TruthParticleContaniner' is not a known C++ template
  'TruthParticleContaniner' is not a known C++ enum

line 131 is where the crash is happening but it is probably due to how the xAOD are open. Since there still discussion going on, I will mark this MR as user action required.

Cheers,

Michele

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 6a45c867 - fix typo

Compare with previous version

This merge request affects 4 packages:

• Control/RootUtils
• PhysicsAnalysis/ElectronPhotonID/PhotonVertexSelection
• Projects/AnalysisBase
• Reconstruction/tauRecTools

Adding @goetz ,@martindl ,@krumnack ,@xiaozhon ,@akraszna ,@adbailey ,@ssnyder ,@rbianchi as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash 6a45c867)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20958]

added 1 commit

• f947061c - turn off test again

Compare with previous version

This merge request affects 4 packages:

• Control/RootUtils
• PhysicsAnalysis/ElectronPhotonID/PhotonVertexSelection
• Projects/AnalysisBase
• Reconstruction/tauRecTools

Adding @goetz ,@martindl ,@krumnack ,@xiaozhon ,@akraszna ,@adbailey ,@ssnyder ,@rbianchi as watchers

CI Result SUCCESS (hash f947061c)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20968]

added review-approved label and removed review-pending-level-1 label

Sigh... I'll just fix that test myself... Let's put this in, as I have some updates lined up myself that should be put on top of this...

resolved all threads

merged

mentioned in commit 4893c5cf

Hi @akraszna,

Thanks. I know this is not your preferred strategy.

I created a ticket for reenabling the test here: https://its.cern.ch/jira/browse/ATLASG-1553

As for the dictionaries: While I appreciate that you want to implement a more thorough solution instead of LoadDictionaries, but may I strongly suggest that as a stop-gap solution you then just load all the dictionaries in xAOD::Init. While that makes jobs a little heavier until the proper solution is deployed, that may be still preferable to adding all the dictionary loading code to all of our code, only to rip it out again in a couple of weeks.

Cheers, Nils

mentioned in merge request !36719 (merged)

added sweep:ignore label