Make AthSimulation more compatible with HepMC3
Make AthSimulation more compatible with HepMC3
- removal of FourVector::rho()
- removal of inlined forward declarations. --> forward headers.
- adding some headers explicitly
- use HepMC::Print compatible with HepMC2 and HepMC3
Tag @jchapman
Merge request reports
Activity
added JetEtmiss LAr Simulation master review-pending-level-1 labels
Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
309 309 //** Add information from HepMcParticleLink to TTree - common for all SimHit types */ 310 310 void ISF::SimHitTreeCreator::addHepMcParticleLinkInfoToTree(HepMcParticleLink &HMPL) { 311 311 if (HMPL.isValid()) { 312 m_momentum = (HMPL.cptr())->momentum().rho(); 312 auto t_mom=(HMPL.cptr())->momentum(); 313 m_momentum = std::sqrt( t_mom.x()*t_mom.x()+t_mom.y()*t_mom.y()+t_mom.z()*t_mom.z()); I think they change the name but it is still there. https://gitlab.cern.ch/hepmc/HepMC3/-/blob/master/include/HepMC3/FourVector.h#L145
Hi @mfauccig ,
the thing is that I myself, co-maintaining that code for some years, have to look inside the headers to recall what
rho()orlength()mean. I bet the chances are low that other people could tell that without looking into headers, i.e. x^2+y^2 vs x^2+y^2+z^2 vs x^2+y^2+z^2-t^2Best regards,
Andrii
- Resolved by Andrii Verbytskyi
added review-user-action-required label and removed review-pending-level-1 label
added review-pending-level-1 label
removed review-user-action-required label
added review-approved label and removed review-pending-level-1 label
mentioned in commit 0c93668f
added sweep:ignore label
