Adding muComb to trigger new JO test

Adding the L2 combined muon step to the trigger new JO test (ATR-20242). The step runs:

• A view data verifier to pick up the L2 SA muons from the previous step
• The ID fast track finding
• the muComb algorithm

Currently it seems that the combined electron+muon chains need to have the same number of steps for electrons and muons, so I split the muon chains into two type. The default chains (used in combination with other signatures) run the L2 SA and combined steps, and the msonly chains run the L2 SA and precision SA steps (and the L2 combined and preicion SA steps are only created for the relevant chains).

This merge request affects 2 packages:

• Trigger/TrigAlgorithms/TrigmuComb
• Trigger/TriggerCommon/TriggerMenuMT

Adding @bernius as watcher

added Trigger TriggerMenu master review-pending-level-1 labels

CI Result SUCCESS (hash 95befe18)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 21096]

added 1 commit

• eba8b65e - Fix compiler warnings

Compare with previous version

This merge request affects 2 packages:

• Trigger/TrigAlgorithms/TrigmuComb
• Trigger/TriggerCommon/TriggerMenuMT

Adding @bernius as watcher

CI Result SUCCESS (hash eba8b65e)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 21119]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit c7250de1

Is this geometry needed fro MS only reco? (i.e. extrapolation?) If you included it here because of ID tracking then ID tracking is insufficiently configured and we needed these in there.

Yeah, the geometry is needed for the extrapolation of the MS tracks, so is independent of the ID tracking.

We would like to have Muon specific tracking flags defined. See here: https://gitlab.cern.ch/atlas/athena/-/blob/master/Trigger/TrigTools/TrigInDetConfig/python/TrigTrackingCutFlags.py However, it is an interesting question where the switch should happen. For electrons I did it in: https://gitlab.cern.ch/atlas/athena/-/blob/master/Trigger/TrigTools/TrigInDetConfig/python/TrigInDetConfig.py#L723

I think ID group would like to retain the control and this switch by themselves.

I agree that we want muon specific flags. I just used the electron flags for the moment since they were already there.

As to where to keep the switch, I also agree it's better to keep this in the ID side, but doesn't this: https://gitlab.cern.ch/atlas/athena/-/blob/master/Trigger/TrigTools/TrigInDetConfig/python/TrigInDetConfig.py#L727

create a new view? I think I initially tried calling this but saw then a new view created which isn't what we want (not sure if it's generally true for all signatures, but I imagine in most cases the ID tracking runs in a view created on the signature side to run ID tracking + some signature code that uses the tracks). So maybe the flag setting should be moved up to TrigInDetConfig?

added sweep:ignore label