Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 157
    • Merge requests 157
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !36844

Attempt to clean up MuonCalibConfig

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Edward Moyse requested to merge emoyse/athena:master-fix-mdtcalibtool-config into master Sep 29, 2020
  • Overview 49
  • Commits 22
  • Pipelines 10
  • Changes 22

I don't think that the approach of modifying the class, rather than an instance, is a good idea. I also worry that private tools are not being configured at all (specifically, the MdtCalibrationTool and MdtCalibrationDbTool). Attempting to fix this.

This meant that I needed to make quite a few other changes, because it turns out that in many cases private tools weren't explicitly configured.

PLEASE MAKE SURE THIS IS SQUASHED the commit history is a big mess but I'm not sure I can face trying to clean it up now.

Shouldn't be merged until after: !37066 (merged) and !36930 (merged)

Tagging @wlampl, @jchapman, @mduehrss

Edited Oct 29, 2020 by Edward Moyse
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: master-fix-mdtcalibtool-config