Skip to content
Snippets Groups Projects

New cell time cut in cluster making

Merged Margherita Spalla requested to merge mspalla/athena:newTimeCutr77 into 21.0

We have added a time cut on calorimeter cells at cluster making stage. The cut is controlled by a flag, currently switched OFF by default. A first version of the time cut has been already merged into 21.0 some time ago (included in 21.0.62 and later). The first version only acted on seed cells, preventing them from seeding a cluster if the cell time exceeds 12.5 ns in absolute value. We have then studied an extended version of the cut, in which seed cells failing the time cut are also prevented from being included into existing clusters (e.g. as neighbouring cells). This MR implements the latter version, in addition to the existing seed-only cut. Two flags are in place, so it is possible to choose either one or the other version of the time cut. Having a the code merged would allow other users and/or developers to independently derive samples with the time cut on, in order to finalise its study.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • hi @mspalla , changes to the code themselves look good, all my comments regard updating the copyright and some cleaning, the later clearly out of the scope of this MR, however it seems like a great opportunity to apply them since they are mostly trivial changes Everything else looks green so as soon as this threads are solved we can approve.

    cheers, Santiago (L1)

  • added 1 commit

    Compare with previous version

  • This merge request affects 1 package:

    • Calorimeter/CaloRec

    Adding @pavol as watcher

  • Hi @snoaccor and @mspalla,

    no changes to the TopoGetter.py beyond what is part of the MR please! The old comments in the getter as still useful documentation. But some of the new commented lines might indeed be related to changes introduced with this MR and can be cleaned of not needed for documenting ...

    Thanks & Cheers, --Sven

  • Santiago Noacco Rosende resolved all threads

    resolved all threads

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading