New cell time cut in cluster making
We have added a time cut on calorimeter cells at cluster making stage. The cut is controlled by a flag, currently switched OFF by default. A first version of the time cut has been already merged into 21.0 some time ago (included in 21.0.62 and later). The first version only acted on seed cells, preventing them from seeding a cluster if the cell time exceeds 12.5 ns in absolute value. We have then studied an extended version of the cut, in which seed cells failing the time cut are also prevented from being included into existing clusters (e.g. as neighbouring cells). This MR implements the latter version, in addition to the existing seed-only cut. Two flags are in place, so it is possible to choose either one or the other version of the time cut. Having a the code merged would allow other users and/or developers to independently derive samples with the time cut on, in order to finalise its study.
Merge request reports
Activity
added Calorimeter review-pending-level-1 labels
CI Result SUCCESS (hash dfe2a13f)Athena AthDataQuality AthSimulation externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthDataQuality: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 44916]- Resolved by Margherita Spalla
- Resolved by Santiago Noacco Rosende
- Resolved by Santiago Noacco Rosende
- Resolved by Santiago Noacco Rosende
- Resolved by Margherita Spalla
- Resolved by Margherita Spalla
- Resolved by Margherita Spalla
hi @mspalla , changes to the code themselves look good, all my comments regard updating the copyright and some cleaning, the later clearly out of the scope of this MR, however it seems like a great opportunity to apply them since they are mostly trivial changes Everything else looks green so as soon as this threads are solved we can approve.
cheers, Santiago (L1)
added review-user-action-required label and removed review-pending-level-1 label
added review-pending-level-1 label and removed review-user-action-required label
no changes to the TopoGetter.py beyond what is part of the MR please! The old comments in the getter as still useful documentation. But some of the new commented lines might indeed be related to changes introduced with this MR and can be cleaned of not needed for documenting ...
Thanks & Cheers, --Sven
- Resolved by Santiago Noacco Rosende
Thanks @menke for the clarification. I don't think I have introduced any additional commented line in the getter, so I guess they will all stay...
Best, M.