Skip to content

Replace use of old RegSelSvc by RegSelTools for the ID

Mark Sutton requested to merge sutt/athena:one into master

The single RegSelSvc is to be replaced by a separate RegSelTool for each subsystem.

This merge request is to implement that migration for the ID code.

This code should contains all the changes that are needed for the full migration away from the RegSelSvc for the Pixel, SCT and TRT.

For information the packages needing changes were

Innerdetector/InDetEventCnv/PixelRawDataByteStreamCnv
InnerDetector/InDetEventCnv/TRT_RawDataByteStreamCnv
InnerDetector/InDetExample/InDetRecExample
InnerDetector/InDetRecAlgs/InDetPrepRawDataFormation
InnerDetector/InDetRecTools/TRT_SeededSpacePointFinderTool

Reconstruction/TRT_Rec
Reconstruction/iPat/iPatRecExample

Innerdetector/InDetExample/InDetTrigRecExample

InnerDetector/InDetTrigRecAlgs/InDetTrigPrepRawDataFormat
InnerDetector/InDetTrigRecAlgs/InDetTrigRawDataProvider
InnerDetector/InDetTrigRecAlgs/SiTrigSPSeededTrackFinder
InnerDetector/InDetTrigRecAlgs/SiTrigSpacePointFormation
InnerDetector/InDetTrigRecAlgs/TRT_TrigSeededTrackFinder
InnerDetector/InDetTrigRecAlgs/TRT_TrigTrackSegmentsFinder

Trigger/TrigTools/TrigOnlineSpacePointTool
Trigger/TriggerCommon/TriggerJobOpts

Trigger/TrigAlgorithms/TrigGenericAlgs
Trigger/TrigAlgorithms/TrigT2MinBias
Trigger/TrigHypothesis/TrigLongLivedParticlesHypo
 
DetectorDescription/RegSelSvcTest
Trigger/TrigAlgorithms/TrigPartialEventBuilding

plus the configuration code for every package using any of the above

In addition, there are changes to the RegSelSvc code and the IDRegionSelector code to remove the generation of the Pixel, and SCT lookup tables using the old InnerDetector/IDRegionSelector code, and remove all the functionality for the Pixel, SCT and TRT from the old RegSelSvc.

In addition, to get round an issue with the PixelCablingCondAlg which seems to report an unusable EventIDRange and causes the RegSelCondAlg to fail for the Pixel detector, there is included a hack such that is uses a large range which should (mostly) work.

This hack should be replaced as soon as possible, by a proper implementation of the PixelCablingCondAlg which no longer needs to set up during the initialise (at least no longer for the RegionSelector)

If the pixel cabling still needs to be configured during initialize() for some other reason, then this range should be fixed such that it provides a valid range for the subsequent use, or over ridden with a usageble value in the execute() method.This complete

This completes the ID migration for ATR-19657

Edited by Mark Sutton

Merge request reports