mark all status codes in AnalysisBase [[nodiscard]]
This mostly matches what the Gaudi status code does as well. Also fixed all the warnings that cropped up for me locally, but as things go, I probably missed something.
We should at some point consolidate the status codes as well (there is no reason to have four), but that is a problem for another day.
cc @akraszna