Skip to content
Snippets Groups Projects

ATLASRECTS-5201: Double to float rel22 FTAG

Merged Sanmay Ganguly requested to merge sanmay/athena:double_float_rel22 into master

WIP branch to track the migration from double to float in FTAG packages in master

JIRA: ATLASRECTS-5201

Edited by Carlo Varni

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Hi @sanmay,

    Also take a look at the trigger-related code that may be affected by this change. I can think of other packages that will collide with this:

    • Trigger/TrigMonitoring/TrigBjetMonitoring
    • Trigger/TrigHypothesis/TrigBjetHypo

    If I get this right, this is still using double so you will not have compilation issues so far. But they will happen once you move to float.

    Also our validation codes (DQ and PHYSVAL) will be affected. Right?

    You should propagate your changes there as well. Tagging also @dguest

    Cheers, C.

    Edited by Carlo Varni
  • Dan Guest
  • Dan Guest
  • Dan Guest
  • Dan Guest
  • Dan Guest
  • Dan Guest
  • Dan Guest
  • Dan Guest
  • Dan Guest
  • Hi @sanmay, do you have news on this?

  • Sanmay Ganguly added 1 commit

    added 1 commit

    • e576031e - renaming the doubles in appropriate functions

    Compare with previous version

  • Jenkins please retry a build

  • This merge request affects 3 packages:

    • Event/xAOD/xAODBTagging
    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkFlavourTag
    • PhysicsAnalysis/JetTagging/JetTagTools

    Adding @nishu ,@rcreager ,@sanmay ,@guirriec ,@akraszna ,@dguest ,@cvarni ,@bdong ,@lidiaz as watchers

  • :white_check_mark: CI Result SUCCESS (hash e576031e)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 22255]

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading