Skip to content
Snippets Groups Projects

xAOD file metadata style

Merged xAOD file metadata style
berghaus/athena:file_metadata_style into master
All threads resolved!
Merged Frank Berghaus requested to merge berghaus/athena:file_metadata_style into master
All threads resolved!

This enforces a style similar to what I picked up from @akraszna's work on EventFormatCnv on all the FileMetaData sources. With these style changes in the functional changes required to make FileMetaData MT-friendly will can be cleanly submitted in a later request.

Note that in the job options snipped I linked the default test AOD. In that way it can just be picked up and used to test the FileMetaData.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Frank Berghaus added 1 commit

    added 1 commit

    • d2f2b8ed - Use three lines instead of one for copyright statement

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Event/xAOD/xAODMetaDataCnv

    Adding @akraszna as watcher

  • Tadej Novak resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash d2f2b8ed)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 21625]

  • Gordon Watts
    Gordon Watts @gwatts ·
    Developer

    Changes look straight forward. Enough, and in a section of the code I'm really not familiar, so asking for a level-2 review.

  • Gordon Watts added review-pending-level-2 label and removed review-pending-level-1 label

    added review-pending-level-2 label and removed review-pending-level-1 label

  • Vakhtang Tsulaia
    Vakhtang Tsulaia @tsulaia ·
    Developer

    Pushing it through, so that Frank can proceed with functional changes.

  • Vakhtang Tsulaia merged

    merged

  • Vakhtang Tsulaia mentioned in commit 95330f6d

    mentioned in commit 95330f6d

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply