Update VP1 to xAOD::EventInfonand prevent crashes when corrupted data used as input
This MR updates VP1Algs
to xAOD::EventInfo
, fixing ATLASVPONE-537.
It also adds safeguards and error messages to prevent crashes when no info for Muons' primaryTrackParticle
is present in the inputr data, fixing ATLASVPONE-538.
Cc: @biliu
Merge request reports
Activity
This merge request affects 4 packages:
- graphics/VP1/VP1Algs
- graphics/VP1/VP1Base
- graphics/VP1/VP1Systems/VP1AODSystems
- graphics/VP1/VP1Systems/VP1TrackSystems
Adding @rbianchi as watcher
added EventDisplay master review-pending-level-1 labels
removed EventDisplay master review-pending-level-1 labels
CI Result SUCCESS (hash ca21e12b)Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 21711]added EventDisplay master review-pending-level-1 labels
A strange thing happened with this MR. I found the labels had been removed...by me! As you can see above, apparently my user removed the labels after having edited the MR's title... but I didn't that, actually. I tried to reproduce this with test MRs but without success; so I cannot say if there is a bug in the GitLab pipeline.
Anyway, I just reactivated the three labels by hand.
added review-pending-level-2 label and removed review-pending-level-1 label
added review-approved label and removed review-pending-level-2 label
mentioned in commit ad880536
added sweep:ignore label