Skip to content
Snippets Groups Projects

CaloClusterCorrection: Cluster correction configuration updates.

Merged CaloClusterCorrection: Cluster correction configuration updates.
ssnyder/athena:config.CaloClusterCorrection-20201011 into master
Merged Scott Snyder requested to merge ssnyder/athena:config.CaloClusterCorrection-20201011 into master

Remove CaloRunClusterCorrection, and remove the remnants of it from the configuration.

Allow reading configuration parameters from a pool file again.

Allow configuring using the global tag again.

Now the sequence of tools is always configured statically, though their parameters may change during the run.

Switch cluster correction configuration to use new-style configuration, and new (CompFactory) configurables.

Add a unit test for cluster correction configuration.

Fix flake8 warnings. Other cleanups.

Merge request reports

Pipeline #2002683 passed

Stage: external

    Pipeline passed for 0b57f513 on ssnyder:config.CaloClusterCorrection-20201011

    Approval is optional

    Merged by Edward MoyseEdward Moyse 4 years ago (Oct 12, 2020 3:31pm UTC)

    Merge details

    • Changes merged into master with a3dedc1b.
    • Deleted the source branch.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      :warning: WARNING: big files (>100K) are found in the changeset

      :pencil: 136K in file Calorimeter/CaloClusterCorrection/python/CaloSwCalibHitsCalibration_v6.py

      :pencil: 212K in file Calorimeter/CaloClusterCorrection/python/CaloSwCalibHitsCalibration_v8.py

      :pencil: 216K in file Calorimeter/CaloClusterCorrection/python/CaloSwCalibHitsCalibration_v9leakdata.py

      :pencil: 100K in file Calorimeter/CaloClusterCorrection/python/CaloSwCalibHitsCalibration_v2.py

      :pencil: 144K in file Calorimeter/CaloClusterCorrection/python/CaloSwCalibHitsCalibration_v6leakdata.py

      :pencil: 1448K in file Calorimeter/CaloClusterCorrection/python/CaloSwEtaoff_v4.py

      :pencil: 100K in file Calorimeter/CaloClusterCorrection/python/CaloSwCalibHitsCalibration_v5_1.py

      :pencil: 208K in file Calorimeter/CaloClusterCorrection/python/CaloSwCalibHitsCalibration_v9.py

      :pencil: 1452K in file Calorimeter/CaloClusterCorrection/python/CaloSwEtaoff_v4_1.py

      :pencil: 104K in file Calorimeter/CaloClusterCorrection/python/CaloSwCalibHitsCalibration_v1.py

      :pencil: 1588K in file Calorimeter/CaloClusterCorrection/python/CaloSwEtaoff_v3.py

      :pencil: 2528K in file Calorimeter/CaloClusterCorrection/python/CaloSwEtaoff_v5.py

      :pencil: 216K in file Calorimeter/CaloClusterCorrection/python/CaloSwCalibHitsCalibration_v8leakdata.py

      :pencil: 100K in file Calorimeter/CaloClusterCorrection/python/CaloSwCalibHitsCalibration_v5.py

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      This merge request affects 1 package:

      • Calorimeter/CaloClusterCorrection

      Adding @pavol as watcher

    • ATLAS Robot added Calorimeter JetEtmiss master review-pending-level-1 labels

      added Calorimeter JetEtmiss master review-pending-level-1 labels

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      :white_check_mark: CI Result SUCCESS (hash 0b57f513)

      Athena AthSimulation AthGeneration AnalysisBase
      externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

      Full details available on this CI monitor view
      :white_check_mark: Athena: number of compilation errors 0, warnings 0
      :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
      :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
      :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
      :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 21742]

    • Damian Gil added review-approved label and removed review-pending-level-1 label

      added review-approved label and removed review-pending-level-1 label

    • Edward Moyse merged

      merged

    • Edward Moyse mentioned in commit a3dedc1b

      mentioned in commit a3dedc1b

    • Atlas Nightlybuild added sweep:ignore label

      added sweep:ignore label

    Please register or sign in to reply