Skip to content
Snippets Groups Projects

Add early rejection to HLT Jet hypo FastReducer tr22145

Merged Peter Sherwood requested to merge peter/athena:master-ATR22145 into master

Test whether enough jets pass initial selection to pass the complete hypo. Reject the event if not.

Affects ATR-22145

@khoo @jbossios

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Peter Sherwood resolved all threads

    resolved all threads

  • Peter Sherwood added 1 commit

    added 1 commit

    • 6b96a422 - Avoid a copy by using a reference in TrigHLTJetHypo/src/FastReducer.cxx

    Compare with previous version

  • This merge request affects 1 package:

    • Trigger/TrigHypothesis/TrigHLTJetHypo
  • :negative_squared_cross_mark: CI Result FAILURE (hash 6b96a422)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 21847]

  • Test time out. Give it another trial

  • Jenkins please retry a build

  • This merge request affects 1 package:

    • Trigger/TrigHypothesis/TrigHLTJetHypo
  • :negative_squared_cross_mark: CI Result FAILURE (hash 6b96a422)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 21863]

  • Please look into the CI test fails due to "CI_TEST/CI_TEST_RUNNER: TEST FAILURE: Trigger_athena_data returned code 1" and "CI_TEST/CI_TEST_RUNNER: TEST FAILURE: Trigger_athena_MC returned code 1". (L1)

  • I guess expectedly the chain HLT_j0_vbenfSEP30etSEP34mass35SEP50fbet_L1J20 now rejects more events, so the references would need to be updated as part of this MR:
    https://atlassoftwaredocs.web.cern.ch/guides/trigger/validation/#continuous-integration-tests

  • Author Developer

    No, this should not happen.

    I have a fix, but am having problems running the ART tests... As soon as this is under control, will update the MR

  • Peter Sherwood added 383 commits

    added 383 commits

    • 6b96a422...2be9c362 - 381 commits from branch atlas:master
    • a47152bc - Modify viability test in FastReductionMatcher:: findInitialJetGroups()
    • 8b7eff52 - Merge remote-tracking branch 'upstream/master' into master-ATR22145

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading