Clean-ups of some of the new job configurations for SCT

• Clean-ups of SCT_DCSConditionsCfg, SCT_SiliconConditionsCfg, SCT_SiPropertiesCfg and SCT_LorentzAngleCfg and their usages in clients.
  • To have similar structure
  • To propagate arguments
  • To avoid duplicates
    • Move the data HLT part to SCT_DCSConditionsCfg
    • Merge SCT_DCSConditionsToolCfg into SCT_DCSConditionsCfg
    • Merge SCT_SiliconConditionsToolCfg into SCT_SiliconConditionsCfg
  • To add SCT_GeometryCfg if SCT_DetectorElementCollection is used
  • To add GeoModelCfg if SCT_ID is use
• Add SCT_SiliconConditionsTestAlgConfig.py to test SCT_SiliconConditionsTestAlg in unit test

python -m SCT_ConditionsAlgorithms.SCT_DCSConditionsTestAlgConfig
python -m SCT_ConditionsAlgorithms.SCT_SiliconConditionsTestAlgConfig
python -m SiPropertiesTool.SCTSiPropertiesTestAlgConfig
python -m SiLorentzAngleTool.SCTSiLorentzAngleTestAlgConfig
InnerDetector/InDetConditions/SCT_ConditionsTools/test/SCT_ConditionsConfig_test.py
InnerDetector/InDetConditions/SiPropertiesTool/test/SiPropertiesConfig_test.py
InnerDetector/InDetConditions/SiLorentzAngleTool/test/SiLorentzAngleConfig_test.py

were OK.

added full-unit-tests label

This merge request affects 6 packages:

• InnerDetector/InDetConditions/SCT_ConditionsAlgorithms
• InnerDetector/InDetConditions/SCT_ConditionsTools
• InnerDetector/InDetConditions/SiLorentzAngleTool
• InnerDetector/InDetConditions/SiPropertiesTool
• InnerDetector/InDetDigitization/SCT_Digitization
• Trigger/TrigTools/TrigInDetConfig

Adding @goetz ,@jchapman ,@sutt ,@oda ,@sroe ,@mvozak ,@nagano as watchers

added Digitization InnerDetector Trigger master review-pending-level-1 labels

mentioned in merge request !37143 (merged)

changed the description

resolved all threads

CI Result FAILURE (hash 4af848a4)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 21828]

added 1 commit

• ecf6f742 - Fix bugs

Compare with previous version

This merge request affects 6 packages:

• InnerDetector/InDetConditions/SCT_ConditionsAlgorithms
• InnerDetector/InDetConditions/SCT_ConditionsTools
• InnerDetector/InDetConditions/SiLorentzAngleTool
• InnerDetector/InDetConditions/SiPropertiesTool
• InnerDetector/InDetDigitization/SCT_Digitization
• Trigger/TrigTools/TrigInDetConfig

Adding @goetz ,@jchapman ,@sutt ,@oda ,@sroe ,@mvozak ,@nagano as watchers

CI Result FAILURE (hash ecf6f742)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 21858]

The required tests failure in AthGeneration is known issue and unrelated to the changes of this MR.

resolved all threads

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 70058a61

added sweep:ignore label