Skip to content
Snippets Groups Projects

Update SCT_RawDataByteStreamCnvConfig.py and use it in clients

Merged Update SCT_RawDataByteStreamCnvConfig.py and use it in clients
oda/athena:master-SCT-decoder-1013 into master
Merged Susumu Oda requested to merge oda/athena:master-SCT-decoder-1013 into master
  • Add prefix, suffix, **kwargs to SCT_RodDecoderCfg. SCTRawDataProviderToolCfg, SCTRawDataProviderCfg, SCTEventFlagWriterCfg
  • Update SCTOverlayConfig.py and TrigInDetConfig.py to use SCTRawDataProviderCfg and SCTEventFlagWriterCfg of SCT_RawDataByteStreamCnvConfig

Not tested yet.

Tag @tadej

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
InnerDetector/InDetRawAlgs/InDetOverlay/python/SCTOverlayConfig.py
29 29 return acc
30 30
31 31
32 def SCTRawDataProviderAlgCfg(flags, name="SCTRawDataProvider", **kwargs):
33 """Return a ComponentAccumulator for SCT raw data provider"""
34 # Temporary until available in the central location
35 acc = ComponentAccumulator()
36
37 kwargs.setdefault("RDOKey", flags.Overlay.BkgPrefix + "SCT_RDOs")
38 kwargs.setdefault("LVL1IDKey", flags.Overlay.BkgPrefix + "SCT_LVL1ID")
39 kwargs.setdefault("BCIDKey", flags.Overlay.BkgPrefix + "SCT_BCID")
40
41 from RegionSelector.RegSelToolConfig import regSelTool_SCT_Cfg
42 kwargs.setdefault("RegSelTool", acc.popToolsAndMerge(regSelTool_SCT_Cfg(flags)))
  • Susumu Oda added 1 commit

    added 1 commit

    • e1531a23 - Use kwargs instead of local sctProviderArgs

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • InnerDetector/InDetEventCnv/SCT_RawDataByteStreamCnv
    • InnerDetector/InDetRawAlgs/InDetOverlay
    • Trigger/TrigTools/TrigInDetConfig

    Adding @goetz ,@jchapman ,@tadej ,@ahaas ,@sutt ,@oda ,@tkharlam ,@sroe ,@mvozak ,@nagano as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 87cac671)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :o: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :o: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :o: Athena: number of compilation errors 1, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 21834]

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash e1531a23)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :o: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :o: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :o: Athena: number of compilation errors 1, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 21835]

  • Susumu Oda added 1 commit

    added 1 commit

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • InnerDetector/InDetEventCnv/SCT_RawDataByteStreamCnv
    • InnerDetector/InDetRawAlgs/InDetOverlay
    • Trigger/TrigTools/TrigInDetConfig

    Adding @goetz ,@jchapman ,@tadej ,@ahaas ,@sutt ,@oda ,@tkharlam ,@sroe ,@mvozak ,@nagano as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 74e25f62)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :o: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 21857]

  • Susumu Oda resolved all threads

    resolved all threads

  • Susumu Oda added 1 commit

    added 1 commit

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • InnerDetector/InDetEventCnv/SCT_RawDataByteStreamCnv
    • InnerDetector/InDetRawAlgs/InDetOverlay
    • Trigger/TrigTools/TrigInDetConfig

    Adding @goetz ,@jchapman ,@tadej ,@ahaas ,@sutt ,@oda ,@tkharlam ,@sroe ,@mvozak ,@nagano as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 77d45b5c)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :o: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 21860]

  • Abhishek Nag
    Abhishek Nag @abnag ·

    Please look into the error in unit test: "AttributeError: module 'GaudiConfig2.Configurables.xAODMaker' has no attribute 'EventFormatStreamHelperTool'" (L1)

  • Abhishek Nag added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Susumu Oda
    Susumu Oda @oda ·
    Author

    The unit test failure in AthGeneration is a known problem and unrelated to the changes in this MR.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
    • Please register or sign in to reply