RelationalCollection+CollectionBase+RootCollection: Fix cppcheck warnings.

Scott Snyderrequested to merge
ssnyder/athena:cppcheckrc.RelationalCollection-20201015 into master
  • Prefer pre-increment (or range-for) to postincrement.
  • Pass class instances by const reference, not by value.

Merge request reports