Master tmdb overlay
MC Overlay included in TMDB for L1 Muon Simulation
Merge request reports
Activity
added Overlay Simulation Tile Trigger labels
Hi @jmendes,
Are these changes intended to be used in pile-up digitization jobs or MC/data Overlay jobs?
Cheers,
John
-
added Digitization JetEtmiss master review-pending-level-1 labels
-
Two quick comments for now. Please also run https://gitlab.cern.ch/atlas/athena/blob/master/Simulation/Tests/OverlayTests/test/test_MCOverlay_ConfigTest_ttbar.sh and https://gitlab.cern.ch/atlas/athena/blob/master/Simulation/Tests/OverlayTests/test/test_MCOverlay_ttbar_Old_vs_New.sh for MC+MC overlay. Data+MC trigger overlay is currently not tested by default.
added review-user-action-required label and removed review-pending-level-1 label
I have run the tests detailed in the following JIRA ticket https://its.cern.ch/jira/browse/ATLASSIM-3637 not easy for me to conclude if they are the same or not. Could though run the ones you ask above.
Resolved by Pavol Strizenec
Athena AthSimulation AthGeneration AnalysisBase externals 
cmake make 
required tests optional tests Full details available on this CI monitor view
added review-pending-level-1 label and removed review-user-action-required label
-
Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
There are errors in the OverlayTier0Test
ERROR Py:diff-root INFO [TileDigitsContainer_p3_MuRcvDigitsCnt.m_cont.m_digits]: 107994 leaves differ
ERROR Py:diff-root INFO [TileMuonReceiverContainer_p1_TileMuRcvCnt.m_data]: 4 leaves differ
ERROR Py:diff-root INFO [TileRawChannelContainer_p1_MuRcvRawChCnt.m_cont.m_data]: 57600 leaves differ
added review-user-action-required label and removed review-pending-level-1 label
added Run2-MCOverlay-output-changed label
added 1 commit
- 3fc3e3f1 - MC Overlay implemented for the TMDB for Run 3 simulation of the L1 muon trigger.
added review-pending-level-1 label and removed review-user-action-required label
Pushed a new version with m_mergeSvc initialization is controlled by an if statement. The leafs differences above reported looks to be from the specific test since I did not detect any difference on the containers on the normal path. This update is in fact to implement the MC overlay for simulations and there is no frozen result to compare with.
-
Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
- Resolved by Joao Gentil Mendes Saraiva
Looking at the regression test the output looks a bit suspicious (all digits have the same value). I suspect configuration also needs to be updated for the change to work.
added review-user-action-required label and removed review-pending-level-1 label
Hi @jmendes ,
this MR was not touched for a while, could you please have a look, and decide what to do with it ?
Thanks, Pavol [as L2 MR shifter]
added 5080 commits
-
3fc3e3f1...0ca124bf - 5076 commits from branch
atlas:master - 10e1401f - Merge remote-tracking branch 'upstream/master' into master-tmdb-overlay
- 86de0ab5 - Merge remote-tracking branch 'upstream/master' into master-tmdb-overlay
- 016a12a9 - Merge remote-tracking branch 'upstream/master' into master-tmdb-overlay
- 25b29b02 - MC Overlay implemented for the TMDB for Run 3 simulation of the L1 muon trigger
Toggle commit list-
3fc3e3f1...0ca124bf - 5076 commits from branch
added review-pending-level-1 label and removed review-user-action-required label
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make required tests optional tests Full details available on this CI monitor view
DQ errors are related to an MR from yesterday (!39772 (merged)). investigating.
Overlay errors look like a problem with this MR, moving back to user to investigate.
-Mike (L1)
added review-approved label
removed review-pending-level-1 label
The digits are rounded and I confirm that the values I see are also close to each other of 12 and most of the time (not always) equal to 11.73. Tile_Pedestal and Tile_Noise are set to false so a fixed value is used from TileInfo.
For the previous version I was not collecting correctly the digits for the different channels correctly and in fact, I was always setting a single set of digits for the different channels. There was in fact an error.
For the current version, this was corrected.
The test I did to avoid confusion with the very close (equal) values that when rounded would get the same value I used the (channel number + 1) to scale the value of the digit.
From the test I saw that the old version would have e.g. 6digit for all channels while the new version would have 1digit, 2*digit, etc... I will attach some output from my side in a later post.
Not sure how usefull it is. Here is the snip for one event using the old (WRONG) snip_1evt_OldVersion
and the new (CORRECT) snip_1evt_NewVersion
-
Hi @jmendes, if you are confident that your changes are correct, then the reference files will have to be updated. As there's another MR pending that also updates the references, we'll have to wait for that one to go in. I'll ping you then with the instructions on how to update them.
In the meantime I'll also have another look at the changes.
FYI @mhance, MRs should NOT be approved if the CI is failing.
added review-user-action-required label and removed review-approved label
I collected all the output in a folder at my cernbox (https://cernbox.cern.ch/index.php/s/I6ctBgEV45NWixo). There is an ERROR appearing?! This is expected ... or is there something that is wrong? And that I can do something about.
d1592.log:Overlay 12:09:35 Py:ComponentAccumulator ERROR This ComponentAccumulator was never merged! d1592.log:Overlay 12:09:35 Py:ComponentAccumulator ERROR This CA contains 7 service, 0 conditions algorithms, 0 event algorithms and 0 public tools d1592.log:Overlay 12:09:35 Py:ComponentAccumulator ERROR This ComponentAccumulator was never merged! d1592.log:Overlay 12:09:35 Py:ComponentAccumulator ERROR This CA contains 29 service, 49 conditions algorithms, 30 event algorithms and 1 public tools d1592.log:PyJobTransforms.trfExe.validate 2021-02-01 12:09:37,036 ERROR Validation of return code failed: Non-zero return code from Overlay (1) (Error code 65)